Page MenuHomePhabricator

[native] Clean up Entry delete action
ClosedPublic

Authored by ashoat on May 31 2024, 6:38 PM.
Tags
None
Referenced Files
F3355839: D12262.id40876.diff
Sat, Nov 23, 3:48 PM
F3354916: D12262.diff
Sat, Nov 23, 1:41 PM
Unknown Object (File)
Mon, Nov 11, 3:46 PM
Unknown Object (File)
Mon, Nov 11, 3:33 PM
Unknown Object (File)
Mon, Nov 11, 12:20 PM
Unknown Object (File)
Mon, Nov 11, 3:55 AM
Unknown Object (File)
Sat, Nov 2, 5:49 AM
Unknown Object (File)
Sat, Nov 2, 5:48 AM
Subscribers
None

Details

Summary

Instead of dispatching an action with an empty payload when we want to skip it, we should skip dispatching an action altogether.

Depends on D12261

Test Plan
  1. Tested with the rest of the stack. Tested entry creation, deletion, deletion while editing, save after editing
  2. Flow and careful code inspection

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable