Page MenuHomePhabricator

[lib][native] update useDeleteDiscardedIdentityAccount to call deletePasswordUser when appropriate
ClosedPublic

Authored by varun on Jun 5 2024, 9:05 PM.
Tags
None
Referenced Files
F2838214: D12325.id41001.diff
Sat, Sep 28, 9:20 PM
Unknown Object (File)
Mon, Sep 16, 7:29 AM
Unknown Object (File)
Sun, Sep 15, 8:56 PM
Unknown Object (File)
Sun, Sep 15, 12:00 PM
Unknown Object (File)
Sun, Sep 15, 11:14 AM
Unknown Object (File)
Wed, Sep 11, 11:23 AM
Unknown Object (File)
Wed, Sep 11, 11:23 AM
Unknown Object (File)
Wed, Sep 11, 11:21 AM
Subscribers
None

Details

Summary

in a later diff, we'll be restricting deleteWalletUser to only be called by wallet accounts. before then, we need username accounts to call deletePasswordUser instead.

Test Plan

tried registering a wallet and password user with my authoritative keyserver offline. confirmed in CloudWatch logs that both accounts were successfully registered and then subsequently deleted when keyserver auth failed. checked that the correct RPC was called each time

Diff Detail

Repository
rCOMM Comm
Branch
delete
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

lib/actions/user-actions.js
385

deleteUserPromise might be a better name, actually

varun requested review of this revision.Jun 5 2024, 9:21 PM
ashoat added inline comments.
lib/actions/user-actions.js
385

Agree

This revision is now accepted and ready to land.Jun 6 2024, 9:53 AM