Page MenuHomePhabricator
Differential D12327

[lib][native] Send backup keys in QR auth only if requested
ClosedPublic
Actions

Authored by bartek on Jun 6 2024, 2:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 8:47 PM
Unknown Object (File)
Sat, Nov 23, 6:48 AM
Unknown Object (File)
Sat, Nov 16, 10:12 AM
Unknown Object (File)
Sun, Nov 10, 1:38 AM
Unknown Object (File)
Oct 16 2024, 6:15 AM
Unknown Object (File)
Oct 16 2024, 4:02 AM
Unknown Object (File)
Oct 15 2024, 4:55 PM
Unknown Object (File)
Oct 15 2024, 4:55 PM
View All 80 Files
Subscribers
tomek

Details

Reviewers
varun
ashoat
Commits
rCOMMe9e330a65dd1: [lib][native] Send backup keys in QR auth only if requested
rCOMMc25b3d672f2a: [lib][native] Send backup keys in QR auth only if requested
Summary

Addresses ENG-8225.
Added a boolean to SECONDARY_DEVICE_REGISTRATION_SUCCESS message that determines if backup keys should be sent.
For keyserver, it can be set to false in D12213.

Test Plan

QR login on native and web. Verified that backup keys are sent, unless hardcoding the flag to false.

Diff Detail

Repository
rCOMM Comm
Branch
barthap/fix2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jun 6 2024, 2:01 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptJun 6 2024, 2:01 AM
bartek mentioned this in D12213: [keyserver] finish secondary login via qr code.Jun 6 2024, 2:03 AM
Harbormaster completed remote builds in B29480: Diff 41033.Jun 6 2024, 2:17 AM
bartek published this revision for review.Jun 6 2024, 5:56 AM
bartek added inline comments.
native/profile/secondary-device-qr-code-scanner.react.js
118–120 ↗(On Diff #41033)

Need this for Flow to properly recognize payload type

ashoat added inline comments.Jun 6 2024, 10:35 AM
native/profile/secondary-device-qr-code-scanner.react.js
128–152 ↗(On Diff #41033)

I would reverse this condition and reduce indentation. See here

ashoat accepted this revision.Jun 6 2024, 10:45 AM

Otherwise seems reasonable

This revision is now accepted and ready to land.Jun 6 2024, 10:45 AM
bartek updated this revision to Diff 41364.Jun 17 2024, 2:13 AM

Reverse condition to reduce indent

Harbormaster completed remote builds in B29704: Diff 41364.Jun 17 2024, 2:29 AM
Closed by commit rCOMMc25b3d672f2a: [lib][native] Send backup keys in QR auth only if requested (authored by bartek). · Explain WhyJun 17 2024, 2:54 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMc25b3d672f2a: [lib][native] Send backup keys in QR auth only if requested.
ashoat added inline comments.Jun 17 2024, 5:34 AM
native/profile/secondary-device-qr-code-scanner.react.js
123 ↗(On Diff #41367)

You missed a return here, so now this diff doesn't really do what it was supposed to (backup logic still executes)

bartek added a reverting change: rCOMM7327c4e2e31a: Revert "[lib][native] Send backup keys in QR auth only if requested".Jun 17 2024, 6:34 AM
bartek reopened this revision.Jun 17 2024, 6:38 AM
This revision is now accepted and ready to land.Jun 17 2024, 6:38 AM
bartek updated this revision to Diff 41388.Jun 17 2024, 6:39 AM

Add missing return statement

Harbormaster completed remote builds in B29719: Diff 41388.Jun 17 2024, 6:56 AM
Closed by commit rCOMMe9e330a65dd1: [lib][native] Send backup keys in QR auth only if requested (authored by bartek). · Explain WhyJun 17 2024, 7:32 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMe9e330a65dd1: [lib][native] Send backup keys in QR auth only if requested.

Revision Contents
Changeset List

PathSize
lib/
hooks/
1 line
types/
tunnelbroker/
2 lines
native/
profile/
12 lines

Diff 41388

View Options

lib/hooks/qr-auth.js

Loading...
View Options

lib/types/tunnelbroker/qr-code-auth-message-types.js

Loading...
View Options

native/profile/secondary-device-qr-code-scanner.react.js

Loading...