Page MenuHomePhabricator
Differential D12582

[web] fix leave channel modal for long thread names
ClosedPublic
Actions

Authored by ginsu on Jun 27 2024, 12:45 AM.
Tags
None
Referenced Files
F2898188: D12582.id41744.diff
Sat, Oct 5, 2:22 AM
F2897610: D12582.diff
Fri, Oct 4, 11:55 PM
Unknown Object (File)
Thu, Sep 26, 8:38 PM
Unknown Object (File)
Thu, Sep 26, 9:43 AM
Unknown Object (File)
Tue, Sep 24, 6:50 PM
Unknown Object (File)
Tue, Sep 24, 3:34 AM
Unknown Object (File)
Fri, Sep 20, 10:31 AM
Unknown Object (File)
Thu, Sep 19, 12:01 PM
View All 56 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
ashoat
Commits
rCOMM1e78a6e4f88a: [web] fix leave channel modal for long thread names
Summary

This fixes a bug where the modal would gorw really wide if the thread name has a really long name. This diff fixes this bug

Linear task: https://linear.app/comm/issue/ENG-8438/leave-channel-modal-on-web-grows-when-a-thread-has-a-really-long-name

Test Plan

Please see the screenshots

Before:

Screenshot 2024-06-27 at 3.42.59 AM.png (1×3 px, 619 KB)

After:

Screenshot 2024-06-27 at 3.43.06 AM.png (2×3 px, 862 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 27 2024, 12:45 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 27 2024, 12:45 AM
ginsu edited the summary of this revision. (Show Details)Jun 27 2024, 12:46 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added a reviewer: inka.
ginsu attached a referenced file: F2125414: Screenshot 2024-06-27 at 3.43.06 AM.png. (Show Details)
ginsu attached a referenced file: F2125413: Screenshot 2024-06-27 at 3.42.59 AM.png. (Show Details)
Harbormaster completed remote builds in B29947: Diff 41744.Jun 27 2024, 1:01 AM
ginsu requested review of this revision.Jun 27 2024, 1:01 AM
ashoat accepted this revision.Jul 1 2024, 11:50 AM

Don't love hardcoding pixel values like this. Should it be a CSS variable?

This revision is now accepted and ready to land.Jul 1 2024, 11:50 AM
ginsu updated this revision to Diff 41861.EditedJul 1 2024, 1:06 PM

address comments + rebase before landing

Harbormaster failed remote builds in B30034: Diff 41861!Jul 1 2024, 1:35 PM
Harbormaster completed remote builds in B30034: Diff 41861.Jul 1 2024, 2:02 PM
Closed by commit rCOMM1e78a6e4f88a: [web] fix leave channel modal for long thread names (authored by ginsu). · Explain WhyJul 1 2024, 8:39 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM1e78a6e4f88a: [web] fix leave channel modal for long thread names.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
2 lines

Diff 41744

View Options

web/modals/threads/confirm-leave-thread-modal.css

Loading...