Page MenuHomePhabricator
Differential D12633

[landing] make footer flush with the bottom of the screen
ClosedPublic
Actions

Authored by ginsu on Mon, Jul 1, 8:31 PM.
Tags
None
Referenced Files
F2232270: D12633.diff
Wed, Jul 10, 3:32 PM
Unknown Object (File)
Mon, Jul 8, 10:38 AM
Unknown Object (File)
Mon, Jul 8, 9:41 AM
Unknown Object (File)
Sun, Jul 7, 9:19 PM
Unknown Object (File)
Sat, Jul 6, 11:01 PM
Unknown Object (File)
Wed, Jul 3, 11:54 AM
Unknown Object (File)
Wed, Jul 3, 11:54 AM
Unknown Object (File)
Wed, Jul 3, 11:54 AM
View All 13 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
inka
Commits
rCOMMdde2391c9409: [landing] make footer flush with the bottom of the screen
Summary

Going through the landing page one more time and found this bug on large screens where the footer was not flushed with the bottom of the screen. This diff fixes this issue

Test Plan

Please see screenshots below

Before:

Screenshot 2024-07-01 at 11.29.42 PM.png (3×5 px, 1 MB)

After:

Screenshot 2024-07-01 at 11.29.53 PM.png (3×5 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Mon, Jul 1, 8:31 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Jul 1, 8:31 PM
ginsu edited the summary of this revision. (Show Details)Mon, Jul 1, 8:37 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu attached a referenced file: F2163614: Screenshot 2024-07-01 at 11.29.53 PM.png. (Show Details)
ginsu attached a referenced file: F2163597: Screenshot 2024-07-01 at 11.29.42 PM.png. (Show Details)
Harbormaster completed remote builds in B30039: Diff 41868.Mon, Jul 1, 8:47 PM
ginsu requested review of this revision.Mon, Jul 1, 8:47 PM
ginsu added reviewers: ashoat, inka.Mon, Jul 1, 9:51 PM
ashoat accepted this revision.Tue, Jul 2, 11:34 AM
This revision is now accepted and ready to land.Tue, Jul 2, 11:34 AM
ginsu updated this revision to Diff 41903.Tue, Jul 2, 1:35 PM
ginsu edited the test plan for this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Tue, Jul 2, 1:36 PM
Closed by commit rCOMMdde2391c9409: [landing] make footer flush with the bottom of the screen (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMdde2391c9409: [landing] make footer flush with the bottom of the screen.
Harbormaster completed remote builds in B30060: Diff 41903.Tue, Jul 2, 1:51 PM

Revision Contents
Changeset List

PathSize
landing/
5 lines

Diff 41903

View Options

landing/landing.css

Loading...