Page MenuHomePhabricator

[native] Disable autoCapitalize for LegacyRegisterPanel and EditPassword
ClosedPublic

Authored by ashoat on Jul 9 2024, 1:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 6:00 AM
Unknown Object (File)
Sun, Dec 22, 6:00 AM
Unknown Object (File)
Sun, Dec 22, 6:00 AM
Unknown Object (File)
Sun, Dec 22, 6:00 AM
Unknown Object (File)
Thu, Dec 5, 5:40 PM
Unknown Object (File)
Tue, Nov 26, 9:26 PM
Unknown Object (File)
Nov 11 2024, 10:12 PM
Unknown Object (File)
Nov 11 2024, 8:51 AM
Subscribers

Details

Summary

Addresses ENG-8602. We want consistency on all password inputs; otherwise, the user will end up with a different string depending on which input they used. I think the mismatch between LegacyRegisterPanel/LogInPanel is contributing to user reports that they forgot their password, or that the password doesn't match up anymore.

A better solution here would be to try to factor out all password inputs in our app, but I didn't have time for that given our launch schedule this month.

Test Plan

This is a really simple diff. I relied on Flow

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

native/chat/settings/delete-thread.react.js
171–181

These were accidentally missed in D6103. I noticed them while searching around the codebase for password inputs

ashoat requested review of this revision.Jul 9 2024, 1:59 PM
This revision is now accepted and ready to land.Jul 9 2024, 2:06 PM