issue: ENG-8710
chats in GENESIS cannot be looking at the list of GENEISS members because every member sees just themselves in GENESIS
Details
Details
tested that it is possible to create a subchannel to a chat in GENESIS
Tested that we see the same list of users as on native both when there is no search text, and when there is some search text
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
On Linear, you asked whether we should check the parent or the top ancestor under GENESIS for permissions. I suggested that the top ancestor made more sense, but I probably care more about consistency with native. What do we do there?
Comment Actions
I answer on linear, so maybe we decide there and update this diff if needed. I fill not land this until we make a decision
Comment Actions
On web we decided that for now we will just not display those users. This will be handled in the next diff
For now it is possible to add any user that shows up in search results. On native we handle this in the UI by showing a popup if the user wants to add someone they cannot:
On web we decided that for now we will just not display those users. This will be handled in the next diff
Comment Actions
Please wrap the previouslySelectedUserIDs declaration is a useMemo before landing! If you disagree or if the feedback doesn't make sense, please re-request review
| web/settings/relationship/add-users-utils.js | ||
|---|---|---|
| 200–245 ↗ | (On Diff #42207) | Love seeing all this custom logic being removed in favor of a shared utility! |
| 211–213 ↗ | (On Diff #42207) | You are creating a new array on every invocation here, which will prevent usePotentialMemberItems from being able to memoize effectively This needs to be wrapped in a React.useMemo |
| 223 ↗ | (On Diff #42207) | I noticed you replaced useSortedENSResolvedUsers with this. Are we sure that the sorting still happens? (Or perhaps userSearchResults does its own sorting that we prefer?) |
Comment Actions
Address review
| web/settings/relationship/add-users-utils.js | ||
|---|---|---|
| 223 ↗ | (On Diff #42207) | This was supposed to better match native, but I can use useSortedENSResolvedUsers |