[web] Allow creating subchannels with no other users
ClosedPublic
Actions

Authored by inka on Jul 11 2024, 5:29 AM.

Details

Reviewers

tomek
kamil

Commits

rCOMMbc6eb2904fbe: [web] Allow creating subchannels with no other users

Summary

issue: [[https://linear.app/comm/issue/ENG-8811/[web]-dont-require-members-when-creating-subchannel | ENG-8811]]
We want to match native and allow creating subchannels with no other users

Test Plan

Tested that it is possible to create a subchannel with no other users
Tested that the created robotext makes sense:
"you created this channel as a child of delete thread with the name "m h""

Diff Detail

Repository

rCOMM Comm

Branch

inka/fix

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jul 11 2024, 5:29 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 11 2024, 5:29 AM

Harbormaster completed remote builds in B30284: Diff 42228.Jul 11 2024, 5:50 AM

inka requested review of this revision.Jul 11 2024, 5:50 AM

tomek accepted this revision.Jul 11 2024, 5:51 AM

This revision is now accepted and ready to land.Jul 11 2024, 5:51 AM

Closed by commit rCOMMbc6eb2904fbe: [web] Allow creating subchannels with no other users (authored by inka). · Explain WhyJul 12 2024, 2:31 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMbc6eb2904fbe: [web] Allow creating subchannels with no other users.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

create/

compose-subchannel-modal.react.js

3 lines

Diff 42228

View Options

web/modals/threads/create/compose-subchannel-modal.react.js

[web] Allow creating subchannels with no other usersClosedPublicActions