This diff prevents prekey handler, platform details synchronizer and user infos handler from making authorized identity calls without having CSAT.
Details
Details
Set usingCommServicesAccessToken = false but remove if statements checking for usingCAST. Ensure that error logs for prekey handler and platform details synchronizer appear in the console. Now apply this diff and ensure that those error logs disapper.
I couldn't figure a good way to test user infos handler but I think that test plan for other components suggests that it will work too since it uses the same check.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-8723
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/components/platform-details-synchronizer.react.js | ||
|---|---|---|
| 14–15 ↗ | (On Diff #42120) | |
| 26 ↗ | (On Diff #42120) | Is this really the right check? I had expected you to add a usingCommServicesAccessToken && commServicesAccessToken check, but it's possible that this is equivalent |
| lib/components/prekeys-handler.react.js | ||
| 25–27 ↗ | (On Diff #42120) | Is this check necessary given the getAuthMetadata check below? |
| lib/components/platform-details-synchronizer.react.js | ||
|---|---|---|
| 26 ↗ | (On Diff #42120) | Check against usingCommServicesAccessToken is present at line 39. |
| lib/components/prekeys-handler.react.js | ||
| 25–27 ↗ | (On Diff #42120) | Theoretically it prevents us from scheduling recurring task that will never do anything. I think this is some benefit but if you disagree this check can be removed. |