Page MenuHomePhabricator

[keyserver] remove unnecessary inviteResponder line in keyserver.js
ClosedPublic

Authored by will on Jul 19 2024, 2:15 PM.
Tags
None
Referenced Files
F3001149: D12808.id42557.diff
Fri, Oct 18, 3:28 AM
F3000981: D12808.id42570.diff
Fri, Oct 18, 3:16 AM
F3000365: D12808.diff
Fri, Oct 18, 1:47 AM
Unknown Object (File)
Thu, Oct 17, 3:47 AM
Unknown Object (File)
Sun, Sep 29, 1:48 PM
Unknown Object (File)
Fri, Sep 27, 9:24 AM
Unknown Object (File)
Sep 12 2024, 7:58 AM
Unknown Object (File)
Sep 9 2024, 8:08 PM
Subscribers

Details

Summary

We're planning on running the webapp, keyserver, and landing page in isolation in separate containers for our prod self-host setup.

This means we should remove this line server.get('/invite/:secret', inviteResponder);

Test Plan

flow check. I believe we plan on testing this on prod and check if the invite links still works. We can fully remove if confirmed working

Diff Detail

Repository
rCOMM Comm
Branch
keyserver_to_aws
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will requested review of this revision.Jul 19 2024, 2:32 PM

Looks like some context in D8255... web doesn't really need this route, landing definitely does, and it's not clear if it's needed at the root either. I think it's fine to remove given we'll be running landing on the apex domain

This revision is now accepted and ready to land.Jul 19 2024, 8:29 PM