Page MenuHomePhabricator

[keyserver] remove unnecessary inviteResponder line in keyserver.js
ClosedPublic

Authored by will on Jul 19 2024, 2:15 PM.
Tags
None
Referenced Files
F3388803: D12808.diff
Fri, Nov 29, 4:03 PM
Unknown Object (File)
Tue, Nov 26, 8:35 AM
Unknown Object (File)
Fri, Nov 1, 11:37 AM
Unknown Object (File)
Fri, Nov 1, 11:37 AM
Unknown Object (File)
Fri, Nov 1, 11:37 AM
Unknown Object (File)
Fri, Nov 1, 11:37 AM
Unknown Object (File)
Oct 18 2024, 3:28 AM
Unknown Object (File)
Oct 18 2024, 3:16 AM
Subscribers

Details

Summary

We're planning on running the webapp, keyserver, and landing page in isolation in separate containers for our prod self-host setup.

This means we should remove this line server.get('/invite/:secret', inviteResponder);

Test Plan

flow check. I believe we plan on testing this on prod and check if the invite links still works. We can fully remove if confirmed working

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will requested review of this revision.Jul 19 2024, 2:32 PM

Looks like some context in D8255... web doesn't really need this route, landing definitely does, and it's not clear if it's needed at the root either. I think it's fine to remove given we'll be running landing on the apex domain

This revision is now accepted and ready to land.Jul 19 2024, 8:29 PM