Page MenuHomePhabricator
Differential D12857

[lib] remove unused Tunnelbroker message validators
ClosedPublic
Actions

Authored by kamil on Jul 23 2024, 6:20 AM.
Tags
None
Referenced Files
F3378246: D12857.id42694.diff
Wed, Nov 27, 9:37 AM
F3377872: D12857.diff
Wed, Nov 27, 7:55 AM
Unknown Object (File)
Fri, Nov 1, 8:15 PM
Unknown Object (File)
Wed, Oct 30, 12:13 AM
Unknown Object (File)
Oct 14 2024, 1:02 PM
Unknown Object (File)
Oct 14 2024, 1:02 PM
Unknown Object (File)
Oct 14 2024, 1:02 PM
Unknown Object (File)
Oct 14 2024, 1:02 PM
View All 58 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMMc6013fa49f0d: [lib] remove unused Tunnelbroker message validators
Summary

ENG-8621.

All files here are messages sent from Device to Tunnelbroker, validation takes place on Rust side and tcomb code is not needed.

Depends on D12856

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Branch
tb
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 23 2024, 6:20 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 23 2024, 6:20 AM
kamil published this revision for review.Jul 23 2024, 6:41 AM
Harbormaster completed remote builds in B30608: Diff 42694.Jul 23 2024, 6:42 AM
kamil added a child revision: D12858: [lib] improve naming in Tunnelbroker socket.Jul 23 2024, 6:45 AM
tomek accepted this revision.Jul 24 2024, 6:04 AM

I'd prefer to also validate on the JS side, but it isn't a strong opinion.

This revision is now accepted and ready to land.Jul 24 2024, 6:04 AM
kamil added a comment.Jul 25 2024, 2:08 AM
In D12857#364153, @tomek wrote:

I'd prefer to also validate on the JS side, but it isn't a strong opinion.

These types are created on the JS side and sent to Rust, but they are never received on JS - validation will be redundant.

Closed by commit rCOMMc6013fa49f0d: [lib] remove unused Tunnelbroker message validators (authored by kamil). · Explain WhyJul 25 2024, 2:54 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMc6013fa49f0d: [lib] remove unused Tunnelbroker message validators.

Revision Contents
Changeset List

Diff 42694

View Options

lib/types/tunnelbroker/message-receive-confirmation-types.js

Loading...
View Options

lib/types/tunnelbroker/message-to-device-request-types.js

Loading...
View Options

lib/types/tunnelbroker/message-to-tunnelbroker-request-types.js

Loading...
View Options

lib/types/tunnelbroker/session-types.js

Loading...