Page MenuHomePhabricator
Differential D12913

[CryptoModule] remove `decryptSequential` API
ClosedPublic
Actions

Authored by kamil on Jul 29 2024, 3:30 AM.
Tags
None
Referenced Files
F3370286: D12913.diff
Tue, Nov 26, 1:47 AM
Unknown Object (File)
Sun, Nov 10, 8:26 AM
Unknown Object (File)
Sun, Nov 10, 6:26 AM
Unknown Object (File)
Sat, Nov 9, 11:36 PM
Unknown Object (File)
Wed, Nov 6, 10:49 PM
Unknown Object (File)
Wed, Oct 30, 10:33 AM
Unknown Object (File)
Wed, Oct 30, 10:30 AM
Unknown Object (File)
Wed, Oct 30, 8:16 AM
View All 56 Files
Subscribers
ashoat

Details

Reviewers
marcin
tomek
Commits
rCOMM885338dacf3a: [CryptoModule] remove `decryptSequential` API
Summary

This is only our wrapper over olm - we don't need it anymore so removing it to cleanup the code and avoid confusing which method should be used. (Removing our wrapper, olm API remains unchanged),

Depends on D12749

Test Plan

Build native app

Diff Detail

Repository
rCOMM Comm
Branch
sequential
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 29 2024, 3:30 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 29 2024, 3:30 AM
kamil published this revision for review.Jul 29 2024, 3:43 AM
kamil edited the summary of this revision. (Show Details)
kamil edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B30738: Diff 42866.Jul 29 2024, 3:46 AM
tomek accepted this revision.Jul 29 2024, 3:56 AM
This revision is now accepted and ready to land.Jul 29 2024, 3:56 AM
Closed by commit rCOMM885338dacf3a: [CryptoModule] remove `decryptSequential` API (authored by kamil). · Explain WhyJul 29 2024, 4:03 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM885338dacf3a: [CryptoModule] remove `decryptSequential` API.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
CryptoTools/
3 lines
10 lines
1 line
45 lines

Diff 42866

View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.h

Loading...
View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp

Loading...
View Options

native/cpp/CommonCpp/CryptoTools/Session.h

Loading...
View Options

native/cpp/CommonCpp/CryptoTools/Session.cpp

Loading...