[lib] Re-broadcast account deletion on own devices
ClosedPublic
Actions

Authored by bartek on Jul 30 2024, 5:54 AM.

Details

Reviewers

kamil

Commits

rCOMMe939fed93850: [lib] Re-broadcast account deletion on own devices

Summary

Address ENG-8606.
When own device receives account deletion message, it re-broadcasts it again. However, it skips own devices to avoid vicious circle.

Depends on D12944

Test Plan

Deleted account when having device list with a secondary device and a peer in auxUserStore.

Verified that both peer and my device received the ACCOUNT_DELETION message.
Additionally, the peer device received it twice.
Both primary and secondary device were logged out

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jul 30 2024, 5:54 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 30 2024, 5:54 AM

Harbormaster completed remote builds in B30815: Diff 42965.Jul 30 2024, 7:07 AM

bartek published this revision for review.Aug 1 2024, 2:02 AM

bartek added inline comments.

lib/tunnelbroker/use-peer-to-peer-message-handler.js
121	Handled in the next diffs

bartek mentioned this in D12944: [lib] Broadcast account deletion message to peers.Aug 1 2024, 6:49 AM

bartek edited the test plan for this revision. (Show Details)

bartek added a child revision: D12961: [lib] Delete auxUserStore users on authoritative keyserver request.Aug 4 2024, 11:43 PM

kamil accepted this revision.Aug 5 2024, 4:45 AM

This revision is now accepted and ready to land.Aug 5 2024, 4:45 AM

Closed by commit rCOMMe939fed93850: [lib] Re-broadcast account deletion on own devices (authored by bartek). · Explain WhyAug 5 2024, 5:54 AM

This revision was automatically updated to reflect the committed changes.

bartek mentioned this in rCOMM0e7b20072836: [lib] Broadcast account deletion message to peers.

bartek added a commit: rCOMMe939fed93850: [lib] Re-broadcast account deletion on own devices.

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

use-peer-to-peer-message-handler.js

33 lines

Diff 42965

View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

[lib] Re-broadcast account deletion on own devicesClosedPublicActions