Page MenuHomePhabricator
Differential D12966

Fix .h file formatting
ClosedPublic
Actions

Authored by inka on Aug 5 2024, 2:17 AM.
Tags
None
Referenced Files
F2786033: D12966.id43147.diff
Fri, Sep 20, 9:32 PM
F2785740: D12966.diff
Fri, Sep 20, 8:03 PM
Unknown Object (File)
Thu, Sep 5, 4:21 PM
Unknown Object (File)
Thu, Sep 5, 4:21 PM
Unknown Object (File)
Thu, Sep 5, 4:21 PM
Unknown Object (File)
Thu, Sep 5, 4:20 PM
Unknown Object (File)
Wed, Sep 4, 5:28 PM
Unknown Object (File)
Sat, Aug 31, 2:58 PM
View All 40 Files
Subscribers
ashoat

Details

Reviewers
ashoat
tomek
marcin
Commits
rCOMM269a31c7bb56: Fix .h file formatting
Summary

Addressing review from D12869
The review was:

  1. Can you add #pragma once to the top?
  2. Can you add line breaks before and after the namespace?
  3. Remove trailing line break

I don't understand what is trailing line break in this file. @ashoat can you explain please?

Test Plan

checked that native app compiles, and there are no changes to .wasm

Diff Detail

Repository
rCOMM Comm
Branch
inka/fix_cap
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Aug 5 2024, 2:17 AM
inka mentioned this in D12869: [native][web] Fill target_message column for sidebar source.Aug 5 2024, 2:17 AM
inka added 1 blocking reviewer(s): ashoat.
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 5 2024, 2:39 AM
Harbormaster failed remote builds in B30884: Diff 43064!
Harbormaster completed remote builds in B30884: Diff 43064.Aug 5 2024, 5:55 AM
inka requested review of this revision.Aug 5 2024, 5:55 AM
tomek accepted this revision.Aug 5 2024, 5:56 AM
ashoat accepted this revision.Aug 5 2024, 7:08 AM

I don't understand what is trailing line break in this file. @ashoat can you explain please?

Sorry about this @inka – I'm actually not sure what I was referring to. I think this is perfect!

This revision is now accepted and ready to land.Aug 5 2024, 7:08 AM
inka added a comment.Aug 5 2024, 7:24 AM

Great, thank you!

Closed by commit rCOMM269a31c7bb56: Fix .h file formatting (authored by inka). · Explain WhyAug 5 2024, 7:26 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM269a31c7bb56: Fix .h file formatting.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
PersistentStorageUtilities/
MessageOperationsUtilities/
3 lines

Diff 43064

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageTypeEnum.h

Loading...