[native] Update to react-native-ffmpeg@0.5.2
AbandonedPublic
Actions

Authored by ashoat on Aug 5 2024, 4:05 PM.

Details

Reviewers

Summary

This addresses ENG-8959 by upgrading the transitive dependency mobile-ffmpeg-min-gpl. Some additional context in ENG-4177.

react-native-ffmpeg is deprecated, and we should migrate to ffmpeg-kit. I don't have time to do that right now, unfortunately.

Depends on D12992

Test Plan

It built on my local environment
Make sure CI passes

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/android

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Aug 5 2024, 4:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptAug 5 2024, 4:05 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 5 2024, 4:20 PM

Harbormaster failed remote builds in B30945: Diff 43160!

Fix iOS by bumping expo-image one patch version to 1.2.3

ashoat published this revision for review.Aug 5 2024, 6:01 PM

will accepted this revision.Aug 5 2024, 6:02 PM

This revision is now accepted and ready to land.Aug 5 2024, 6:02 PM

Harbormaster completed remote builds in B30948: Diff 43163.Aug 5 2024, 6:17 PM

Unfortunately this update seems to break RNFFprobe.getMediaInformation, at least on iOS. More details here and here, but suffice it to say that if we ever need to revisit this, we'll probably need to proceed with the full migration to ffmpeg-kit (tracked here).