[lib] Extract userSurfacedPermissionsFromRolePermissions
ClosedPublic
Actions

Authored by ashoat on Aug 13 2024, 12:50 PM.

Details

Reviewers

tomek
inka

Commits

rCOMM6eceaca2615d: [lib] Extract userSurfacedPermissionsFromRolePermissions

Summary

This diff extracts a function from useRoleUserSurfacedPermissions, which I'm naming userSurfacedPermissionsFromRolePermissions.

We want to use this extracted function to address ENG-9031. It will be called by the keyserver from updateRoles to determine the currently-selected set of user-surfaced permissions.

Depends on D13068

Test Plan

This is a simple move diff. Besides Flow, it was also tested in combination with subsequent diffs

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Aug 13 2024, 12:50 PM

ashoat added a child revision: D13074: [keyserver][lib] Restrict updateRoles endpoint to ThinThreadType.

Harbormaster completed remote builds in B31082: Diff 43368.Aug 13 2024, 1:08 PM

ashoat requested review of this revision.Aug 13 2024, 1:08 PM

tomek accepted this revision.Aug 14 2024, 8:37 AM

This revision is now accepted and ready to land.Aug 14 2024, 8:37 AM

Closed by commit rCOMM6eceaca2615d: [lib] Extract userSurfacedPermissionsFromRolePermissions (authored by ashoat). · Explain WhyAug 14 2024, 9:50 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6eceaca2615d: [lib] Extract userSurfacedPermissionsFromRolePermissions.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

25 lines

utils/

role-utils.js

19 lines

Diff 43368

View Options

lib/shared/thread-utils.js