Page MenuHomePhabricator
Differential D13073

[lib] Extract userSurfacedPermissionsFromRolePermissions
ClosedPublic
Actions

Authored by ashoat on Aug 13 2024, 12:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 11, 9:27 PM
Unknown Object (File)
Fri, Apr 4, 12:24 PM
Unknown Object (File)
Fri, Apr 4, 5:51 AM
Unknown Object (File)
Thu, Apr 3, 8:57 PM
Unknown Object (File)
Thu, Apr 3, 3:47 PM
Unknown Object (File)
Mar 9 2025, 12:03 PM
Unknown Object (File)
Feb 22 2025, 11:12 PM
Unknown Object (File)
Feb 22 2025, 11:12 PM
View All 76 Files
Subscribers
None

Details

Reviewers
tomek
inka
Commits
rCOMM6eceaca2615d: [lib] Extract userSurfacedPermissionsFromRolePermissions
Summary

This diff extracts a function from useRoleUserSurfacedPermissions, which I'm naming userSurfacedPermissionsFromRolePermissions.

We want to use this extracted function to address ENG-9031. It will be called by the keyserver from updateRoles to determine the currently-selected set of user-surfaced permissions.

Depends on D13068

Test Plan

This is a simple move diff. Besides Flow, it was also tested in combination with subsequent diffs

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
25 lines
utils/
19 lines

Diff 43368

View Options

lib/shared/thread-utils.js

Show First 20 Lines • Show All 263 Lines • ▼ Show 20 Lines unsafe extern "C++" {
fn get_backup_directory_path() -> Result<String>; fn get_backup_directory_path() -> Result<String>;
#[allow(unused)] #[allow(unused)]
#[cxx_name = "getBackupFilePath"] #[cxx_name = "getBackupFilePath"]
fn get_backup_file_path( fn get_backup_file_path(
backup_id: String, backup_id: String,
is_attachments: bool, is_attachments: bool,
) -> Result<String>; ) -> Result<String>;
#[allow(unused)]
#[cxx_name = "createMainCompaction"]
fn create_main_compaction(backup_id: String) -> Result<()>;
#[allow(unused)]
#[cxx_name = "restoreFromMainCompaction"]
fn restore_from_main_compaction(
main_compaction_path: String,
main_compaction_encryption_key: String,
) -> Result<()>;
} }
} }
fn handle_string_result_as_callback<E>( fn handle_string_result_as_callback<E>(
result: Result<String, E>, result: Result<String, E>,
promise_id: u32, promise_id: u32,
) where ) where
E: std::fmt::Display, E: std::fmt::Display,
▲ Show 20 Lines • Show All 896 Lines • Show Last 20 Lines
View Options

lib/utils/role-utils.js

Show First 20 Lines • Show All 263 Lines • ▼ Show 20 Lines unsafe extern "C++" {
fn get_backup_directory_path() -> Result<String>; fn get_backup_directory_path() -> Result<String>;
#[allow(unused)] #[allow(unused)]
#[cxx_name = "getBackupFilePath"] #[cxx_name = "getBackupFilePath"]
fn get_backup_file_path( fn get_backup_file_path(
backup_id: String, backup_id: String,
is_attachments: bool, is_attachments: bool,
) -> Result<String>; ) -> Result<String>;
#[allow(unused)]
#[cxx_name = "createMainCompaction"]
fn create_main_compaction(backup_id: String) -> Result<()>;
#[allow(unused)]
#[cxx_name = "restoreFromMainCompaction"]
fn restore_from_main_compaction(
main_compaction_path: String,
main_compaction_encryption_key: String,
) -> Result<()>;
} }
} }
fn handle_string_result_as_callback<E>( fn handle_string_result_as_callback<E>(
result: Result<String, E>, result: Result<String, E>,
promise_id: u32, promise_id: u32,
) where ) where
E: std::fmt::Display, E: std::fmt::Display,
▲ Show 20 Lines • Show All 896 Lines • Show Last 20 Lines