It looks like both REACT_TO_MESSAGE and EDIT_MESSAGE should be safe to move, since their client checks go through useThreadHasPermission, and the keyserver checks go through checkThreadPermission / checkThread.

However, the check for MANAGE_PINS on the keyserver side is not safe. It goes through canToggleMessagePin, which calls threadHasPermission directly. Since it doesn't currently consider block status, we would need to refactor the check to make it work correctly for threadPermissionsNotAffectedByBlock. (The Flow types would catch this if we tried to move it.)

I'll make the change for the first two. I can create a follow-up for MANAGE_PINS if you'd like, but I suspect this isn't a very important case (by default, only admins have this permission anyways, and the block does not affect admins).

I suspect this isn't a very important case (by default, only admins have this permission anyways, and the block does not affect admins).

Makes sense! In that case, we don't need the follow-up.