Page MenuHomePhabricator

[native] Fix broken StyleProps type for react-native-reanimated libdef
ClosedPublic

Authored by ashoat on Aug 20 2024, 9:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 2:09 AM
Unknown Object (File)
Fri, Nov 8, 2:09 AM
Unknown Object (File)
Fri, Nov 8, 1:42 AM
Unknown Object (File)
Fri, Oct 25, 2:37 AM
Unknown Object (File)
Oct 4 2024, 8:28 PM
Unknown Object (File)
Sep 25 2024, 12:41 AM
Unknown Object (File)
Sep 25 2024, 12:41 AM
Unknown Object (File)
Sep 25 2024, 12:40 AM
Subscribers
None

Details

Summary

This issue was first introduced in D5556, and led to a $FlowFixMe being introduced in D13066.

It's not possible to spread a non-object. I remove the spreads here because the only relevant part of the union is the object form ({ [name: string]: any, ... }), which is already included in the StyleProps type anyways.

This diff addresses part of ENG-9039.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/flow
Lint
No Lint Coverage
Unit
No Test Coverage