Use notificationsCreationData from queueFront in peer-to-peer-context
ClosedPublic
Actions

Authored by marcin on Aug 29 2024, 6:40 AM.

Details

Reviewers

Commits

rCOMM6186db449ce6: Use notificationsCreationData from queueFront in peer-to-peer-context

Summary

Kamil detected that E2EE notifs work non-deterministically. The main issue is this but I think that change fixed in this might had contributed here as well.

Test Plan

Test for D13123

Diff Detail

Repository

rCOMM Comm

Branch

marcin/quick-notif-fix

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Aug 29 2024, 6:40 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 29 2024, 6:41 AM

marcin published this revision for review.Aug 29 2024, 6:41 AM

tomek accepted this revision.Aug 29 2024, 6:44 AM

This revision is now accepted and ready to land.Aug 29 2024, 6:44 AM

Harbormaster completed remote builds in B31366: Diff 43798.Aug 29 2024, 7:00 AM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 29 2024, 9:04 AM

Closed by commit rCOMM6186db449ce6: Use notificationsCreationData from queueFront in peer-to-peer-context (authored by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMM6186db449ce6: Use notificationsCreationData from queueFront in peer-to-peer-context.

Harbormaster completed remote builds in B31367: Diff 43810.Aug 29 2024, 9:10 AM

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

peer-to-peer-context.js

2 lines

Diff 43798

View Options

lib/tunnelbroker/peer-to-peer-context.js

	// @flow			// @flow

				import type { NotificationsCreationData } from './notif-types.js';
	import type { StoreOperations } from './store-ops-types.js';			import type { StoreOperations } from './store-ops-types.js';

	export type MessageSourceMetadata = {			export type MessageSourceMetadata = {
	+messageID: string,			+messageID: string,
	+senderDeviceID: string,			+senderDeviceID: string,
	};			};

	export type DBOpsEntry =			export type DBOpsEntry =
	\| {			\| {
	+messageSourceMetadata: MessageSourceMetadata,			+messageSourceMetadata: MessageSourceMetadata,
	+ops?: ?StoreOperations,			+ops?: ?StoreOperations,
	}			}
	\| {			\| {
	+ops: StoreOperations,			+ops: StoreOperations,
	+dmOpID?: string,			+dmOpID?: string,
				}
				\| {
				+notificationsCreationData?: NotificationsCreationData,
	};			};

	export type DBOpsStore = {			export type DBOpsStore = {
	+queuedOps: $ReadOnlyArray<DBOpsEntry>,			+queuedOps: $ReadOnlyArray<DBOpsEntry>,
	};			};

Use notificationsCreationData from queueFront in peer-to-peer-contextClosedPublicActions