Page MenuHomePhabricator
Differential D13123

Update sendDMOperation to send notifs as well
ClosedPublic
Actions

Authored by marcin on Tue, Aug 20, 7:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 13, 1:06 PM
Unknown Object (File)
Fri, Sep 13, 12:16 PM
Unknown Object (File)
Sun, Sep 8, 10:13 AM
Unknown Object (File)
Sat, Sep 7, 2:19 PM
Unknown Object (File)
Fri, Sep 6, 11:53 PM
Unknown Object (File)
Fri, Sep 6, 11:53 PM
Unknown Object (File)
Fri, Sep 6, 2:36 PM
Unknown Object (File)
Fri, Sep 6, 8:39 AM
View All 52 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMMd3d04d03bc67: Update sendDMOperation to send notifs as well
Summary

This differential updates sendDMOperation to create and send notifs as well

Test Plan
  1. Apply this patch: https://gist.github.com/marcinwasowicz/2db9332e8d59225d5549fe2e4e29d4cf
  2. Send message from web to native client.
  3. Ensure that client displays a list of different notifications including:
    1. text message notif
    2. thread creation notif
    3. reaction notif
    4. thread settings change notifs
    5. sidebar creation notif

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Tue, Aug 20, 7:56 AM
Herald added a subscriber: ashoat. · View Herald TranscriptTue, Aug 20, 7:56 AM
marcin added a parent revision: D13121: Implement method to go from DMOperation -> [MessageData] for each dm op spec.Tue, Aug 20, 7:58 AM
Harbormaster completed remote builds in B31179: Diff 43510.Tue, Aug 20, 8:29 AM
marcin requested review of this revision.Tue, Aug 20, 8:29 AM
marcin edited the test plan for this revision. (Show Details)Tue, Aug 20, 8:34 AM
marcin added a child revision: D13131: Fix sound issue for peer-based notifications.Wed, Aug 21, 4:19 AM
marcin updated this revision to Diff 43551.Wed, Aug 21, 5:07 AM
marcin edited the test plan for this revision. (Show Details)

Reflect changes in parent differential

Harbormaster completed remote builds in B31197: Diff 43551.Wed, Aug 21, 5:24 AM
marcin updated this revision to Diff 43558.Wed, Aug 21, 10:07 AM

Reorder the stack

marcin removed a child revision: D13131: Fix sound issue for peer-based notifications.Wed, Aug 21, 10:08 AM
marcin added a parent revision: D13010: Update db ops reducer to process notiications creation data.Wed, Aug 21, 10:10 AM
marcin removed a parent revision: D13121: Implement method to go from DMOperation -> [MessageData] for each dm op spec.
Harbormaster failed remote builds in B31204: Diff 43558!Wed, Aug 21, 10:13 AM
marcin added a child revision: D13163: Implement DMOperation and relevant spec for thread status change.Mon, Aug 26, 4:47 AM
marcin updated this revision to Diff 43676.Tue, Aug 27, 5:41 AM

Move notification sending logic to peer-to-peer-context

Harbormaster completed remote builds in B31284: Diff 43676.Tue, Aug 27, 6:00 AM
kamil accepted this revision.Tue, Aug 27, 8:09 AM
kamil added inline comments.
lib/shared/dm-ops/process-dm-ops.js
120–129 ↗(On Diff #43676)
lib/tunnelbroker/peer-to-peer-context.js
243–249 ↗(On Diff #43676)

could you make sure that none of those two promises throws?

This revision is now accepted and ready to land.Tue, Aug 27, 8:09 AM
marcin added inline comments.Tue, Aug 27, 8:37 AM
lib/shared/dm-ops/process-dm-ops.js
120–129 ↗(On Diff #43676)

Flow doesn't accept this.

marcin updated this revision to Diff 43708.Tue, Aug 27, 10:55 AM

Rebase before landing

Harbormaster completed remote builds in B31307: Diff 43708.Tue, Aug 27, 11:30 AM
Closed by commit rCOMMd3d04d03bc67: Update sendDMOperation to send notifs as well (authored by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain WhyTue, Aug 27, 11:30 AM
This revision was automatically updated to reflect the committed changes.
Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMMd3d04d03bc67: Update sendDMOperation to send notifs as well.
marcin mentioned this in D13207: Use notificationsCreationData from queueFront in peer-to-peer-context.Thu, Aug 29, 6:40 AM
Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> mentioned this in rCOMM6186db449ce6: Use notificationsCreationData from queueFront in peer-to-peer-context.Thu, Aug 29, 9:04 AM

Revision Contents
Changeset List

PathSize
lib/
handlers/
8 lines
push/
7 lines
shared/
dm-ops/
15 lines
tunnelbroker/
39 lines

Diff 43715

View Options

lib/handlers/db-ops-handler.react.js

Loading...
View Options

lib/push/send-hooks.react.js

Loading...
View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...
View Options

lib/tunnelbroker/peer-to-peer-context.js

Loading...