Page MenuHomePhabricator

Enrich CommMMKV api with operations that manipulate string set
ClosedPublic

Authored by marcin on Aug 26 2024, 5:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 1:18 PM
Unknown Object (File)
Tue, Oct 22, 8:32 AM
Unknown Object (File)
Tue, Oct 22, 8:32 AM
Unknown Object (File)
Sun, Oct 20, 9:50 PM
Unknown Object (File)
Fri, Oct 18, 8:40 PM
Unknown Object (File)
Fri, Oct 18, 7:26 PM
Unknown Object (File)
Fri, Oct 18, 7:25 PM
Unknown Object (File)
Fri, Oct 18, 7:54 AM
Subscribers

Details

Summary

This differential enriches CommMMKV api with new methods that add, remove and get size of set of strings stored in MMKV under some key. The purpose here is to keep list of unread thick threads in MMKV and updated it and use it from notifs code to handle the bacge icon update.

Test Plan

Tested in next differential

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Refactor getStringSetSize to getStringSet

tomek added inline comments.
native/android/app/src/main/java/app/comm/android/fbjni/CommMMKV.java
181 ↗(On Diff #43725)

We can simplify it

This revision is now accepted and ready to land.Aug 30 2024, 3:03 AM