The context is here. In this differential we disable encryption of sound property for peer notifications.
Details
Details
- Reviewers
tomek kamil - Commits
- rCOMM44b5ff880b3a: Fix sound issue for peer-based notifications
Ensure that peer notifications make sound. Execute parent differential test plan and ensure that each delivered notification makes sound.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
- Are there any other APNs fields that we need to surface outside of the encrypted blob like this? For instance, how about priority?
- Do we have a similar problem with other encrypted notifs, such as the FCM ones we use for Android?
Comment Actions
Sound was the only one. The priority field is not a part of notification but a part of headers of HTTP request to APNS which are never encrypted.
- Do we have a similar problem with other encrypted notifs, such as the FCM ones we use for Android?
No, we don't send notification sound on Android. It is set locally on when notifications channel is first created. See here. createChannel implementation is in native code here. It does not mention sound but according to documentation notifications sent to this channel will make sound since its importance is HIGH. The value of this sound is some default set by the system. User can change it in settings.