Paths

Table of Contentst

Differential D13163

Implement DMOperation and relevant spec for thread status change
ClosedPublic
Actions

Authored by marcin on Aug 26 2024, 4:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 9, 3:34 PM

	Unknown Object (File)
	Sat, Nov 9, 9:10 AM

	Unknown Object (File)
	Sat, Nov 9, 8:54 AM

	Unknown Object (File)
	Sat, Nov 9, 4:13 AM

	Unknown Object (File)
	Sat, Nov 9, 3:51 AM

	Unknown Object (File)
	Fri, Nov 8, 11:23 PM

	Unknown Object (File)
	Fri, Nov 8, 2:25 AM

	Unknown Object (File)
	Sun, Nov 3, 9:08 PM

View All 55 Files

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMMd628fcc1f493: Implement DMOperation and relevant spec for thread status change

Summary

This differential implements DMOperationSpec for change thread unread status operation.

Test Plan

Apply this patch: https://gist.github.com/marcinwasowicz/d9f3365facba9e226284f470141a531e
Open two browser windows and log in with the same user.
Send text message in one window.
Ensure that new thread is created on both browser windows.
Ensure that after 5 seconds this thread becomes unread on both browser windows.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Aug 26 2024, 4:45 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 26 2024, 4:45 AM

marcin added a parent revision: D13123: Update sendDMOperation to send notifs as well.Aug 26 2024, 4:47 AM

marcin added a child revision: D13164: Implement code in lib to create thick threads rescinds and badge updates.Aug 26 2024, 4:54 AM

Harbormaster completed remote builds in B31252: Diff 43627.Aug 26 2024, 5:02 AM

marcin requested review of this revision.Aug 26 2024, 5:02 AM

tomek accepted this revision.Aug 27 2024, 12:57 AM

tomek added inline comments.

lib/types/dm-ops.js
33 ↗	(On Diff #43627)	I think this name is confusing and it needs to be more detailed.
322 ↗	(On Diff #43627)	We don't use it when creating an update, but it is used during validation, which makes sense.

This revision is now accepted and ready to land.Aug 27 2024, 12:57 AM

Rename CHANGE_THREAD_STATUS_SPEC -> CHANGE_THREAD_READ_STATUS_SPEC

Harbormaster completed remote builds in B31390: Diff 43835.Sep 2 2024, 9:18 AM

Rebase before landing

Harbormaster completed remote builds in B31413: Diff 43859.Sep 3 2024, 7:44 AM

Closed by commit rCOMMd628fcc1f493: Implement DMOperation and relevant spec for thread status change (authored by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain WhySep 3 2024, 8:20 AM

This revision was automatically updated to reflect the committed changes.

Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMMd628fcc1f493: Implement DMOperation and relevant spec for thread status change.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

change-thread-read-status-spec.js

54 lines

2 lines

types/

21 lines

Diff 43868

lib/shared/dm-ops/change-thread-read-status-spec.js

Loading...

lib/shared/dm-ops/dm-op-specs.js

Loading...

lib/types/dm-ops.js

Loading...