Page MenuHomePhabricator
Differential D13163

Implement DMOperation and relevant spec for thread status change
ClosedPublic
Actions

Authored by marcin on Mon, Aug 26, 4:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 13, 2:03 AM
Unknown Object (File)
Thu, Sep 12, 1:46 AM
Unknown Object (File)
Wed, Sep 11, 9:46 AM
Unknown Object (File)
Wed, Sep 11, 9:34 AM
Unknown Object (File)
Tue, Sep 10, 4:43 AM
Unknown Object (File)
Tue, Sep 10, 2:37 AM
Unknown Object (File)
Mon, Sep 9, 3:35 PM
Unknown Object (File)
Mon, Sep 9, 2:15 PM
View All 36 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMMd628fcc1f493: Implement DMOperation and relevant spec for thread status change
Summary

This differential implements DMOperationSpec for change thread unread status operation.

Test Plan
  1. Apply this patch: https://gist.github.com/marcinwasowicz/d9f3365facba9e226284f470141a531e
  2. Open two browser windows and log in with the same user.
  3. Send text message in one window.
  4. Ensure that new thread is created on both browser windows.
  5. Ensure that after 5 seconds this thread becomes unread on both browser windows.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Mon, Aug 26, 4:45 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMon, Aug 26, 4:45 AM
marcin added a parent revision: D13123: Update sendDMOperation to send notifs as well.Mon, Aug 26, 4:47 AM
marcin added a child revision: D13164: Implement code in lib to create thick threads rescinds and badge updates.Mon, Aug 26, 4:54 AM
Harbormaster completed remote builds in B31252: Diff 43627.Mon, Aug 26, 5:02 AM
marcin requested review of this revision.Mon, Aug 26, 5:02 AM
tomek accepted this revision.Tue, Aug 27, 12:57 AM
tomek added inline comments.
lib/types/dm-ops.js
33 ↗(On Diff #43627)

I think this name is confusing and it needs to be more detailed.

322 ↗(On Diff #43627)

We don't use it when creating an update, but it is used during validation, which makes sense.

This revision is now accepted and ready to land.Tue, Aug 27, 12:57 AM
marcin updated this revision to Diff 43835.Mon, Sep 2, 9:01 AM

Rename CHANGE_THREAD_STATUS_SPEC -> CHANGE_THREAD_READ_STATUS_SPEC

Harbormaster completed remote builds in B31390: Diff 43835.Mon, Sep 2, 9:18 AM
marcin updated this revision to Diff 43859.Tue, Sep 3, 7:28 AM

Rebase before landing

Harbormaster completed remote builds in B31413: Diff 43859.Tue, Sep 3, 7:44 AM
Closed by commit rCOMMd628fcc1f493: Implement DMOperation and relevant spec for thread status change (authored by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain WhyTue, Sep 3, 8:20 AM
This revision was automatically updated to reflect the committed changes.
Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMMd628fcc1f493: Implement DMOperation and relevant spec for thread status change.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
54 lines
2 lines
types/
21 lines

Diff 43868

View Options

lib/shared/dm-ops/change-thread-read-status-spec.js

Loading...
View Options

lib/shared/dm-ops/dm-op-specs.js

Loading...
View Options

lib/types/dm-ops.js

Loading...