Paths

Table of Contentst

Differential D13123

Update sendDMOperation to send notifs as well
ClosedPublic
Actions

Authored by marcin on Aug 20 2024, 7:56 AM.

Tags

None

Referenced Files

	F3506260: D13123.diff
	Fri, Dec 20, 3:56 PM

	F3502491: D13123.id43551.diff
	Fri, Dec 20, 4:18 AM

	Unknown Object (File)
	Wed, Dec 18, 5:03 PM

	Unknown Object (File)
	Wed, Dec 18, 3:57 PM

	Unknown Object (File)
	Wed, Dec 18, 3:57 PM

	Unknown Object (File)
	Wed, Dec 18, 3:57 PM

	Unknown Object (File)
	Wed, Dec 18, 3:56 PM

	Unknown Object (File)
	Thu, Nov 21, 12:44 AM

View All 82 Files

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMMd3d04d03bc67: Update sendDMOperation to send notifs as well

Summary

This differential updates sendDMOperation to create and send notifs as well

Test Plan

Apply this patch: https://gist.github.com/marcinwasowicz/2db9332e8d59225d5549fe2e4e29d4cf
Send message from web to native client.
Ensure that client displays a list of different notifications including:
1. text message notif
2. thread creation notif
3. reaction notif
4. thread settings change notifs
5. sidebar creation notif

Diff Detail

Repository

Branch

marcin/eng-8284-new

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Aug 20 2024, 7:56 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 20 2024, 7:56 AM

marcin added a parent revision: D13121: Implement method to go from DMOperation -> [MessageData] for each dm op spec.Aug 20 2024, 7:58 AM

Harbormaster completed remote builds in B31179: Diff 43510.Aug 20 2024, 8:29 AM

marcin requested review of this revision.Aug 20 2024, 8:29 AM

marcin edited the test plan for this revision. (Show Details)Aug 20 2024, 8:34 AM

marcin added a child revision: D13131: Fix sound issue for peer-based notifications.Aug 21 2024, 4:19 AM

Reflect changes in parent differential

Harbormaster completed remote builds in B31197: Diff 43551.Aug 21 2024, 5:24 AM

Reorder the stack

marcin removed a child revision: D13131: Fix sound issue for peer-based notifications.Aug 21 2024, 10:08 AM

marcin added a parent revision: D13010: Update db ops reducer to process notiications creation data.Aug 21 2024, 10:10 AM

marcin removed a parent revision: D13121: Implement method to go from DMOperation -> [MessageData] for each dm op spec.

Harbormaster failed remote builds in B31204: Diff 43558!Aug 21 2024, 10:13 AM

marcin added a child revision: D13163: Implement DMOperation and relevant spec for thread status change.Aug 26 2024, 4:47 AM

Move notification sending logic to peer-to-peer-context

Harbormaster completed remote builds in B31284: Diff 43676.Aug 27 2024, 6:00 AM

kamil accepted this revision.Aug 27 2024, 8:09 AM

kamil added inline comments.

lib/shared/dm-ops/process-dm-ops.js
120–129 ↗	(On Diff #43676)
lib/tunnelbroker/peer-to-peer-context.js
243–249 ↗	(On Diff #43676)	could you make sure that none of those two promises throws?

This revision is now accepted and ready to land.Aug 27 2024, 8:09 AM

marcin added inline comments.Aug 27 2024, 8:37 AM

lib/shared/dm-ops/process-dm-ops.js
120–129 ↗	(On Diff #43676)	Flow doesn't accept this.

Rebase before landing

Harbormaster completed remote builds in B31307: Diff 43708.Aug 27 2024, 11:30 AM

Closed by commit rCOMMd3d04d03bc67: Update sendDMOperation to send notifs as well (authored by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain WhyAug 27 2024, 11:30 AM

This revision was automatically updated to reflect the committed changes.

Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMMd3d04d03bc67: Update sendDMOperation to send notifs as well.

marcin mentioned this in D13207: Use notificationsCreationData from queueFront in peer-to-peer-context.Aug 29 2024, 6:40 AM

Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> mentioned this in rCOMM6186db449ce6: Use notificationsCreationData from queueFront in peer-to-peer-context.Aug 29 2024, 9:04 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

17 lines

tunnelbroker/

peer-to-peer-context.js

18 lines

Diff 43510

lib/shared/dm-ops/dm-op-utils.js

Loading...

lib/tunnelbroker/peer-to-peer-context.js

Loading...