Paths

Table of Contentst

-
keyserver/src/database/
-
src/
-
database/
-
migrations.js

[keyserver] only wrap migration in transaction if specified in migrationType
ClosedPublic
Actions

Authored by will on Aug 30 2024, 8:29 AM.

Details

Reviewers

varun
ashoat

Commits

rCOMM13bc5582d73e: [keyserver] only wrap migration in transaction if specified in migrationType

Summary

If the migration type is wrap_in_transaction_and_block_requests, we wrap the migration in a transaction. Only if it was wrapped in transaction do we run rollback if the query failed.

Depends on D13209

Test Plan

I console logged and made sure that transaction and rollback queries were only being run if the migration in migrations specified wrapping in a transaction.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Aug 30 2024, 8:29 AM

Herald added a subscriber: tomek. · View Herald TranscriptAug 30 2024, 8:29 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 30 2024, 8:40 AM

Harbormaster failed remote builds in B31372: Diff 43816!

Harbormaster completed remote builds in B31372: Diff 43816.Aug 30 2024, 9:00 AM

will requested review of this revision.Aug 30 2024, 9:00 AM

will added 1 blocking reviewer(s): ashoat.Sep 3 2024, 8:01 AM

ashoat accepted this revision.Sep 4 2024, 11:20 PM

ashoat added inline comments.

keyserver/src/database/migrations.js
51–52	Let's avoid copy-pasting these two lines. Can't we just individually wrap `startTransaction` and `commitTransaction` in the conditional?

This revision is now accepted and ready to land.Sep 4 2024, 11:20 PM

will added inline comments.Sep 5 2024, 6:51 AM

keyserver/src/database/migrations.js
51–52	That makes sense! I originally had them both individually wrapped but thought this looked cleaner. I'll go by the maxim of reducing copy-paste of non-conditionals from now on

review feedback

will added a child revision: D13213: [keyserver] stall secondary nodes until database version is equal to or greater than latest wrapped in transaction request blocking migration version..Sep 8 2024, 8:18 PM

Harbormaster completed remote builds in B31474: Diff 43952.Sep 8 2024, 8:18 PM

Closed by commit rCOMM13bc5582d73e: [keyserver] only wrap migration in transaction if specified in migrationType (authored by will). · Explain WhySep 8 2024, 9:48 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM13bc5582d73e: [keyserver] only wrap migration in transaction if specified in migrationType.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

database/

migrations.js

19 lines

Diff 43816

View Options

keyserver/src/database/migrations.js

// @flow		// @flow

import type { PossiblyStaleNavigationState } from '@react-navigation/native';		import type { PossiblyStaleNavigationState } from '@react-navigation/native';
		import { useRoute } from '@react-navigation/native';
import _memoize from 'lodash/memoize.js';		import _memoize from 'lodash/memoize.js';
import * as React from 'react';		import * as React from 'react';
import { createSelector } from 'reselect';		import { createSelector } from 'reselect';

import { nonThreadCalendarFiltersSelector } from 'lib/selectors/calendar-filter-selectors.js';		import { nonThreadCalendarFiltersSelector } from 'lib/selectors/calendar-filter-selectors.js';
import { currentCalendarQuery } from 'lib/selectors/nav-selectors.js';		import { currentCalendarQuery } from 'lib/selectors/nav-selectors.js';
		import { useCanEditMessage } from 'lib/shared/edit-messages-utils.js';
import type { CalendarQuery } from 'lib/types/entry-types.js';		import type { CalendarQuery } from 'lib/types/entry-types.js';
import type { CalendarFilter } from 'lib/types/filter-types.js';		import type { CalendarFilter } from 'lib/types/filter-types.js';
		import type {
		ComposableMessageInfo,
		RobotextMessageInfo,
		MessageInfo,
		} from 'lib/types/message-types.js';
		import type { ThreadInfo } from 'lib/types/thread-types.js';

import type { NavContextType } from './navigation-context.js';		import type { NavContextType } from './navigation-context.js';
import { NavContext } from './navigation-context.js';		import { NavContext } from './navigation-context.js';
import {		import {
getStateFromNavigatorRoute,		getStateFromNavigatorRoute,
getThreadIDFromRoute,		getThreadIDFromRoute,
currentLeafRoute,		currentLeafRoute,
} from './navigation-utils.js';		} from './navigation-utils.js';
import {		import {
AppRouteName,		AppRouteName,
TabNavigatorRouteName,		TabNavigatorRouteName,
MessageListRouteName,		MessageListRouteName,
ChatRouteName,		ChatRouteName,
CalendarRouteName,		CalendarRouteName,
ThreadPickerModalRouteName,		ThreadPickerModalRouteName,
ActionResultModalRouteName,		ActionResultModalRouteName,
accountModals,		accountModals,
scrollBlockingModals,		scrollBlockingModals,
chatRootModals,		chatRootModals,
threadRoutes,		threadRoutes,
CommunityDrawerNavigatorRouteName,		CommunityDrawerNavigatorRouteName,
		MessageResultsScreenRouteName,
		MessageSearchRouteName,
} from './route-names.js';		} from './route-names.js';
import type { RemoveEditMode } from '../chat/message-list-types';		import type { RemoveEditMode } from '../chat/message-list-types';
import { useSelector } from '../redux/redux-utils.js';		import { useSelector } from '../redux/redux-utils.js';
import type { NavPlusRedux } from '../types/selector-types.js';		import type { NavPlusRedux } from '../types/selector-types.js';
import type { GlobalTheme } from '../types/themes.js';		import type { GlobalTheme } from '../types/themes.js';

const baseCreateIsForegroundSelector = (routeName: string) =>		const baseCreateIsForegroundSelector = (routeName: string) =>
createSelector(		createSelector(
▲ Show 20 Lines • Show All 343 Lines • ▼ Show 20 Lines	function useCurrentLeafRouteName(): ?string {
return React.useMemo(() => {		return React.useMemo(() => {
if (!navContext) {		if (!navContext) {
return undefined;		return undefined;
}		}
return currentLeafRoute(navContext.state).name;		return currentLeafRoute(navContext.state).name;
}, [navContext]);		}, [navContext]);
}		}

		function useCanEditMessageNative(
		threadInfo: ThreadInfo,
		messageInfo: MessageInfo,
		targetMessageInfo: ComposableMessageInfo \| RobotextMessageInfo,
		): boolean {
		const route = useRoute();

		const screenKey = route.key;
		const threadCreationTime = threadInfo.creationTime;
		const messageCreationTime = messageInfo.time;

		const canEditInThisScreen =
		!screenKey.startsWith(MessageSearchRouteName) &&
		!screenKey.startsWith(MessageResultsScreenRouteName) &&
		messageCreationTime > threadCreationTime;
		tomekUnsubmitted Not Done Inline Actions Should we use `>=`? tomek: Should we use `>=`?

		return (
		useCanEditMessage(threadInfo, targetMessageInfo) && canEditInThisScreen
		);
		}

export {		export {
createIsForegroundSelector,		createIsForegroundSelector,
useIsAppLoggedIn,		useIsAppLoggedIn,
createActiveTabSelector,		createActiveTabSelector,
scrollBlockingModalsClosedSelector,		scrollBlockingModalsClosedSelector,
selectBackgroundIsDark,		selectBackgroundIsDark,
activeThreadSelector,		activeThreadSelector,
activeMessageListSelector,		activeMessageListSelector,
useActiveThread,		useActiveThread,
useActiveMessageList,		useActiveMessageList,
calendarActiveSelector,		calendarActiveSelector,
nativeCalendarQuery,		nativeCalendarQuery,
nonThreadCalendarQuery,		nonThreadCalendarQuery,
useCalendarQuery,		useCalendarQuery,
drawerSwipeEnabledSelector,		drawerSwipeEnabledSelector,
useCurrentLeafRouteName,		useCurrentLeafRouteName,
getRemoveEditMode,		getRemoveEditMode,
getTabNavState,		getTabNavState,
getChatNavStateFromTabNavState,		getChatNavStateFromTabNavState,
		useCanEditMessageNative,
};		};

[keyserver] only wrap migration in transaction if specified in migrationTypeClosedPublicActions