If the migration type is wrap_in_transaction_and_block_requests, we wrap the migration in a transaction. Only if it was wrapped in transaction do we run rollback if the query failed.
Depends on D13209
Details
Details
I console logged and made sure that transaction and rollback queries were only being run if the migration in migrations specified wrapping in a transaction.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/src/database/migrations.js | ||
|---|---|---|
| 51–52 ↗ | (On Diff #43816) | Let's avoid copy-pasting these two lines. Can't we just individually wrap startTransaction and commitTransaction in the conditional? |
| keyserver/src/database/migrations.js | ||
|---|---|---|
| 51–52 ↗ | (On Diff #43816) | That makes sense! I originally had them both individually wrapped but thought this looked cleaner. I'll go by the maxim of reducing copy-paste of non-conditionals from now on |