Paths

Table of Contentst

Differential D13271

Fix input types from D13050
ClosedPublic
Actions

Authored by marcin on Sep 9 2024, 6:23 AM.

Tags

None

Referenced Files

	F3509001: D13271.id44038.diff
	Sat, Dec 21, 12:28 AM

	F3508848: D13271.id44037.diff
	Sat, Dec 21, 12:01 AM

	F3508836: D13271.id44011.diff
	Fri, Dec 20, 11:57 PM

	F3508769: D13271.id43990.diff
	Fri, Dec 20, 11:52 PM

	F3508648: D13271.id43988.diff
	Fri, Dec 20, 11:20 PM

	F3508510: D13271.id43989.diff
	Fri, Dec 20, 10:35 PM

	F3507547: D13271.diff
	Fri, Dec 20, 9:11 PM

	Unknown Object (File)
	Mon, Dec 16, 5:10 AM

View All 69 Files

Subscribers

Details

Reviewers

Commits

rCOMM0e2412f00c19: Fix input types from D13050

Summary

This differential fixes types according to Ashoat suggestion: https://phab.comm.dev/D13050#inline-76348

Test Plan

flow

Diff Detail

Repository

Branch

marcin/eng-fix-D13050

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Sep 9 2024, 6:23 AM

Herald added a subscriber: tomek. · View Herald TranscriptSep 9 2024, 6:23 AM

marcin mentioned this in D13050: Extract logic of pushInfo -> usersToCollapsableNotifInfo to lib and use for client-based notifs.Sep 9 2024, 6:33 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 9 2024, 6:40 AM

Harbormaster failed remote builds in B31495: Diff 43988!

Fix flow in the keyserver

Fix flow

Harbormaster completed remote builds in B31496: Diff 43989.Sep 9 2024, 7:14 AM

Harbormaster completed remote builds in B31497: Diff 43990.Sep 9 2024, 7:22 AM

marcin requested review of this revision.Sep 9 2024, 7:22 AM

Thanks for doing this! Please apply the inline changes before landing, or otherwise re-request review if it introduces Flow errors

lib/push/send-utils.js
97 ↗	(On Diff #43990)
307 ↗	(On Diff #43990)
353 ↗	(On Diff #43990)

This revision is now accepted and ready to land.Sep 9 2024, 1:42 PM

Update types

I applied changes from latest @ashoat suggestion but it forced me to change mergeUserToCollapsableInfo to perform deeper copy that initial single spread. Therefore re-requesting review.

Harbormaster completed remote builds in B31510: Diff 44011.Sep 10 2024, 9:55 AM

Thanks! I considered keeping the inputs to mergeUserToCollapsableInfo mutable, but I wasn't able to quickly confirm that it was safe... so I think this is the best bet

This revision is now accepted and ready to land.Sep 10 2024, 12:31 PM

Rebase before landing

This revision was landed with ongoing or failed builds.Sep 11 2024, 5:17 AM

Closed by commit rCOMM0e2412f00c19: Fix input types from D13050 (authored by marcin). · Explain Why

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM0e2412f00c19: Fix input types from D13050.

Harbormaster completed remote builds in B31531: Diff 44037.Sep 11 2024, 5:26 AM

Revision Contents
Changeset List

Path

Size

lib/

push/

8 lines

Diff 43988

lib/push/send-utils.js

Loading...