Page MenuHomePhabricator
Differential D13271

Fix input types from D13050
ClosedPublic
Actions

Authored by marcin on Mon, Sep 9, 6:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 17, 7:28 AM
Unknown Object (File)
Tue, Sep 17, 5:09 AM
Unknown Object (File)
Tue, Sep 17, 4:38 AM
Unknown Object (File)
Tue, Sep 17, 4:04 AM
Unknown Object (File)
Tue, Sep 17, 2:11 AM
Unknown Object (File)
Mon, Sep 16, 11:53 PM
Unknown Object (File)
Mon, Sep 16, 7:21 PM
Unknown Object (File)
Mon, Sep 16, 6:57 AM
View All 26 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM0e2412f00c19: Fix input types from D13050
Summary

This differential fixes types according to Ashoat suggestion: https://phab.comm.dev/D13050#inline-76348

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-fix-D13050
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Mon, Sep 9, 6:23 AM
Herald added a subscriber: tomek. · View Herald TranscriptMon, Sep 9, 6:23 AM
marcin mentioned this in D13050: Extract logic of pushInfo -> usersToCollapsableNotifInfo to lib and use for client-based notifs.Mon, Sep 9, 6:33 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Sep 9, 6:40 AM
Harbormaster failed remote builds in B31495: Diff 43988!
marcin updated this revision to Diff 43989.Mon, Sep 9, 6:57 AM

Fix flow in the keyserver

marcin updated this revision to Diff 43990.Mon, Sep 9, 6:59 AM

Fix flow

Harbormaster completed remote builds in B31496: Diff 43989.Mon, Sep 9, 7:14 AM
Harbormaster completed remote builds in B31497: Diff 43990.Mon, Sep 9, 7:22 AM
marcin requested review of this revision.Mon, Sep 9, 7:22 AM
ashoat accepted this revision.Mon, Sep 9, 1:42 PM

Thanks for doing this! Please apply the inline changes before landing, or otherwise re-request review if it introduces Flow errors

lib/push/send-utils.js
97 ↗(On Diff #43990)
307 ↗(On Diff #43990)
353 ↗(On Diff #43990)
This revision is now accepted and ready to land.Mon, Sep 9, 1:42 PM
marcin updated this revision to Diff 44011.Tue, Sep 10, 9:38 AM

Update types

marcin requested review of this revision.Tue, Sep 10, 9:41 AM

I applied changes from latest @ashoat suggestion but it forced me to change mergeUserToCollapsableInfo to perform deeper copy that initial single spread. Therefore re-requesting review.

Harbormaster completed remote builds in B31510: Diff 44011.Tue, Sep 10, 9:55 AM
ashoat accepted this revision.Tue, Sep 10, 12:31 PM

Thanks! I considered keeping the inputs to mergeUserToCollapsableInfo mutable, but I wasn't able to quickly confirm that it was safe... so I think this is the best bet

This revision is now accepted and ready to land.Tue, Sep 10, 12:31 PM
marcin updated this revision to Diff 44037.Wed, Sep 11, 5:06 AM

Rebase before landing

This revision was landed with ongoing or failed builds.Wed, Sep 11, 5:17 AM
Closed by commit rCOMM0e2412f00c19: Fix input types from D13050 (authored by marcin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM0e2412f00c19: Fix input types from D13050.
Harbormaster completed remote builds in B31531: Diff 44037.Wed, Sep 11, 5:26 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
4 lines
lib/
push/
26 lines

Diff 44037

View Options

keyserver/src/push/send.js

Loading...
View Options

lib/push/send-utils.js

Loading...