[lib] Modify add viewer to members operation so that creating a message is optional
ClosedPublic
Actions

Authored by tomek on Sep 12 2024, 5:22 AM.

Details

Reviewers

kamil
inka

Commits

rCOMM461aa6451f43: [lib] Modify add viewer to members operation so that creating a message is…

Summary

When one user's device shares threads with the other, we don't want to create robotext messages.

https://linear.app/comm/issue/ENG-9241/introduce-a-handler-that-sends-operations-to-new-devices

Depends on D13292

Test Plan

Process an operation with and without the message ID and check if the message was created only in the first case.

Diff Detail

Repository

rCOMM Comm

Branch

improvements

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Sep 12 2024, 5:22 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 12 2024, 5:22 AM

tomek edited the summary of this revision. (Show Details)Sep 12 2024, 5:22 AM

tomek added a parent revision: D13292: [lib] Allow sending operations to some devices.

Harbormaster completed remote builds in B31559: Diff 44077.Sep 12 2024, 5:39 AM

tomek requested review of this revision.Sep 12 2024, 5:39 AM

tomek added a child revision: D13307: [lib] Share the state with a new device.Sep 12 2024, 7:33 AM

kamil accepted this revision.Sep 13 2024, 5:03 AM

This revision is now accepted and ready to land.Sep 13 2024, 5:03 AM

Closed by commit rCOMM461aa6451f43: [lib] Modify add viewer to members operation so that creating a message is… (authored by tomek). · Explain WhySep 13 2024, 5:40 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM461aa6451f43: [lib] Modify add viewer to members operation so that creating a message is….

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

add-viewer-to-thread-members-spec.js

6 lines

types/

dm-ops.js

6 lines

Diff 44077

View Options

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js