[lib] Allow reacting and creating sidebars from failed messages in thick threads
ClosedPublic
Actions

Authored by tomek on Sep 17 2024, 7:58 AM.

Details

Reviewers

kamil
will

Commits

rCOMMa80f96b3c214: [lib] Allow reacting and creating sidebars from failed messages in thick threads

Summary

https://linear.app/comm/issue/ENG-9313/consider-allowing-creating-sidebars-from-messages-that-failed#comment-dc22d82f

Test Plan

Checked on native and web if the actions are present for failed messages in thick threads and aren't present for failed messages in thin threads.

Diff Detail

Repository

rCOMM Comm

Branch

merge

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Sep 17 2024, 7:58 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 17 2024, 7:58 AM

Harbormaster completed remote builds in B31666: Diff 44270.Sep 17 2024, 8:17 AM

tomek requested review of this revision.Sep 17 2024, 8:17 AM

will added inline comments.Sep 17 2024, 8:27 AM

lib/shared/sidebar-utils.js
209 ↗	(On Diff #44270)	Assuming this is leftover?
237 ↗	(On Diff #44270)	Also assuming we should remove this before landing

Accepting assuming landing without console logs

This revision is now accepted and ready to land.Sep 17 2024, 8:31 AM

Delete logs

Harbormaster completed remote builds in B31678: Diff 44288.Sep 18 2024, 3:39 AM

Closed by commit rCOMMa80f96b3c214: [lib] Allow reacting and creating sidebars from failed messages in thick threads (authored by tomek). · Explain WhySep 18 2024, 7:03 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMa80f96b3c214: [lib] Allow reacting and creating sidebars from failed messages in thick threads.

Revision Contents
Changeset List

Path

Size

lib/

shared/

reaction-utils.js

6 lines

sidebar-utils.js

5 lines

Diff 44288

View Options

lib/shared/reaction-utils.js