Page MenuHomePhabricator
Differential D13412

[lib] Merge viewerID into ProcessDMOperationUtilities
ClosedPublic
Actions

Authored by ashoat on Sep 20 2024, 6:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 9:03 AM
Unknown Object (File)
Sat, Mar 15, 3:41 AM
Unknown Object (File)
Feb 24 2025, 8:40 PM
Unknown Object (File)
Feb 24 2025, 11:09 AM
Unknown Object (File)
Feb 20 2025, 9:14 AM
Unknown Object (File)
Feb 18 2025, 2:26 PM
Unknown Object (File)
Feb 16 2025, 3:45 PM
Unknown Object (File)
Feb 15 2025, 6:39 PM
View All 59 Files
Subscribers
None

Details

Reviewers
kamil
tomek
Commits
rCOMM8703bff04d40: [lib] Merge viewerID into ProcessDMOperationUtilities
Summary

Following feedback in D13391.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/relationship
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Sep 20 2024, 6:30 AM
ashoat mentioned this in D13391: [lib] Add viewerID to DMOperationSpec.notificationsCreationData.Sep 20 2024, 6:31 AM
Harbormaster completed remote builds in B31741: Diff 44375.Sep 20 2024, 6:52 AM
ashoat requested review of this revision.Sep 20 2024, 6:52 AM
kamil accepted this revision.Sep 20 2024, 7:12 AM
kamil added inline comments.
lib/shared/dm-ops/process-dm-ops.js
86–89

is it needed? Why can't we keep using baseUtilities?

This revision is now accepted and ready to land.Sep 20 2024, 7:12 AM
ashoat added inline comments.Sep 20 2024, 7:53 AM
lib/shared/dm-ops/process-dm-ops.js
86–89

Flow needed this

Closed by commit rCOMM8703bff04d40: [lib] Merge viewerID into ProcessDMOperationUtilities (authored by ashoat). · Explain WhySep 20 2024, 7:55 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM8703bff04d40: [lib] Merge viewerID into ProcessDMOperationUtilities.

Revision Contents
Changeset List

Diff 44375

View Options

lib/shared/dm-ops/add-members-spec.js

Show All 34 Lines
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import { TooltipProvider } from './chat/tooltip-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
Show All 15 Lines
import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js'; import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js';
import AccountSettings from './settings/account-settings.react.js'; import AccountSettings from './settings/account-settings.react.js';
import DangerZone from './settings/danger-zone.react.js'; import DangerZone from './settings/danger-zone.react.js';
import KeyserverSelectionList from './settings/keyserver-selection-list.react.js'; import KeyserverSelectionList from './settings/keyserver-selection-list.react.js';
import CommunityPicker from './sidebar/community-picker.react.js'; import CommunityPicker from './sidebar/community-picker.react.js';
import Splash from './splash/splash.react.js'; import Splash from './splash/splash.react.js';
import './typography.css'; import './typography.css';
import css from './style.css'; import css from './style.css';
import { TooltipProvider } from './tooltips/tooltip-provider.js';
import { type NavInfo } from './types/nav-types.js'; import { type NavInfo } from './types/nav-types.js';
import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js'; import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js';
void initOpaque(); void initOpaque();
// We want Webpack's css-loader and style-loader to handle the Fontawesome CSS, // We want Webpack's css-loader and style-loader to handle the Fontawesome CSS,
// so we disable the autoAddCss logic and import the CSS file. Otherwise every // so we disable the autoAddCss logic and import the CSS file. Otherwise every
// icon flashes huge for a second before the CSS is loaded. // icon flashes huge for a second before the CSS is loaded.
▲ Show 20 Lines • Show All 325 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js

Show All 34 Lines
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import { TooltipProvider } from './chat/tooltip-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
Show All 15 Lines
import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js'; import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js';
import AccountSettings from './settings/account-settings.react.js'; import AccountSettings from './settings/account-settings.react.js';
import DangerZone from './settings/danger-zone.react.js'; import DangerZone from './settings/danger-zone.react.js';
import KeyserverSelectionList from './settings/keyserver-selection-list.react.js'; import KeyserverSelectionList from './settings/keyserver-selection-list.react.js';
import CommunityPicker from './sidebar/community-picker.react.js'; import CommunityPicker from './sidebar/community-picker.react.js';
import Splash from './splash/splash.react.js'; import Splash from './splash/splash.react.js';
import './typography.css'; import './typography.css';
import css from './style.css'; import css from './style.css';
import { TooltipProvider } from './tooltips/tooltip-provider.js';
import { type NavInfo } from './types/nav-types.js'; import { type NavInfo } from './types/nav-types.js';
import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js'; import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js';
void initOpaque(); void initOpaque();
// We want Webpack's css-loader and style-loader to handle the Fontawesome CSS, // We want Webpack's css-loader and style-loader to handle the Fontawesome CSS,
// so we disable the autoAddCss logic and import the CSS file. Otherwise every // so we disable the autoAddCss logic and import the CSS file. Otherwise every
// icon flashes huge for a second before the CSS is loaded. // icon flashes huge for a second before the CSS is loaded.
▲ Show 20 Lines • Show All 325 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/change-thread-read-status-spec.js

Show All 34 Lines
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import { TooltipProvider } from './chat/tooltip-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
Show All 15 Lines
import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js'; import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js';
import AccountSettings from './settings/account-settings.react.js'; import AccountSettings from './settings/account-settings.react.js';
import DangerZone from './settings/danger-zone.react.js'; import DangerZone from './settings/danger-zone.react.js';
import KeyserverSelectionList from './settings/keyserver-selection-list.react.js'; import KeyserverSelectionList from './settings/keyserver-selection-list.react.js';
import CommunityPicker from './sidebar/community-picker.react.js'; import CommunityPicker from './sidebar/community-picker.react.js';
import Splash from './splash/splash.react.js'; import Splash from './splash/splash.react.js';
import './typography.css'; import './typography.css';
import css from './style.css'; import css from './style.css';
import { TooltipProvider } from './tooltips/tooltip-provider.js';
import { type NavInfo } from './types/nav-types.js'; import { type NavInfo } from './types/nav-types.js';
import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js'; import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js';
void initOpaque(); void initOpaque();
// We want Webpack's css-loader and style-loader to handle the Fontawesome CSS, // We want Webpack's css-loader and style-loader to handle the Fontawesome CSS,
// so we disable the autoAddCss logic and import the CSS file. Otherwise every // so we disable the autoAddCss logic and import the CSS file. Otherwise every
// icon flashes huge for a second before the CSS is loaded. // icon flashes huge for a second before the CSS is loaded.
▲ Show 20 Lines • Show All 325 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/change-thread-settings-spec.js

Show All 34 Lines
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import { TooltipProvider } from './chat/tooltip-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
Show All 15 Lines
import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js'; import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js';
import AccountSettings from './settings/account-settings.react.js'; import AccountSettings from './settings/account-settings.react.js';
import DangerZone from './settings/danger-zone.react.js'; import DangerZone from './settings/danger-zone.react.js';
import KeyserverSelectionList from './settings/keyserver-selection-list.react.js'; import KeyserverSelectionList from './settings/keyserver-selection-list.react.js';
import CommunityPicker from './sidebar/community-picker.react.js'; import CommunityPicker from './sidebar/community-picker.react.js';
import Splash from './splash/splash.react.js'; import Splash from './splash/splash.react.js';
import './typography.css'; import './typography.css';
import css from './style.css'; import css from './style.css';
import { TooltipProvider } from './tooltips/tooltip-provider.js';
import { type NavInfo } from './types/nav-types.js'; import { type NavInfo } from './types/nav-types.js';
import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js'; import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js';
void initOpaque(); void initOpaque();
// We want Webpack's css-loader and style-loader to handle the Fontawesome CSS, // We want Webpack's css-loader and style-loader to handle the Fontawesome CSS,
// so we disable the autoAddCss logic and import the CSS file. Otherwise every // so we disable the autoAddCss logic and import the CSS file. Otherwise every
// icon flashes huge for a second before the CSS is loaded. // icon flashes huge for a second before the CSS is loaded.
▲ Show 20 Lines • Show All 325 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/change-thread-subscription.js

Show All 34 Lines
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import { TooltipProvider } from './chat/tooltip-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
Show All 15 Lines
import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js'; import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js';
import AccountSettings from './settings/account-settings.react.js'; import AccountSettings from './settings/account-settings.react.js';
import DangerZone from './settings/danger-zone.react.js'; import DangerZone from './settings/danger-zone.react.js';
import KeyserverSelectionList from './settings/keyserver-selection-list.react.js'; import KeyserverSelectionList from './settings/keyserver-selection-list.react.js';
import CommunityPicker from './sidebar/community-picker.react.js'; import CommunityPicker from './sidebar/community-picker.react.js';
import Splash from './splash/splash.react.js'; import Splash from './splash/splash.react.js';
import './typography.css'; import './typography.css';
import css from './style.css'; import css from './style.css';
import { TooltipProvider } from './tooltips/tooltip-provider.js';
import { type NavInfo } from './types/nav-types.js'; import { type NavInfo } from './types/nav-types.js';
import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js'; import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js';
void initOpaque(); void initOpaque();
// We want Webpack's css-loader and style-loader to handle the Fontawesome CSS, // We want Webpack's css-loader and style-loader to handle the Fontawesome CSS,
// so we disable the autoAddCss logic and import the CSS file. Otherwise every // so we disable the autoAddCss logic and import the CSS file. Otherwise every
// icon flashes huge for a second before the CSS is loaded. // icon flashes huge for a second before the CSS is loaded.
▲ Show 20 Lines • Show All 325 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/create-entry-spec.js

Loading...
View Options

lib/shared/dm-ops/create-sidebar-spec.js

Loading...
View Options

lib/shared/dm-ops/create-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/delete-entry-spec.js

Loading...
View Options

lib/shared/dm-ops/dm-op-spec.js

Loading...
View Options

lib/shared/dm-ops/edit-entry-spec.js

Loading...
View Options

lib/shared/dm-ops/join-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/leave-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...
View Options

lib/shared/dm-ops/remove-members-spec.js

Loading...
View Options

lib/shared/dm-ops/send-edit-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-multimedia-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-reaction-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-text-message-spec.js

Loading...
View Options

lib/shared/dm-ops/update-relationship-spec.js

Loading...