[lib] avoid creating `notificationsCreationData` on `DMOperation` received from other peer
ClosedPublic
Actions

Authored by kamil on Thu, Sep 19, 6:14 AM.

Details

Reviewers

tomek
marcin

Commits

rCOMM2b686b3c4b7b: [lib] avoid creating `notificationsCreationData` on `DMOperation` received from…

Summary

Looks like we're generating notificationsCreationData even when DMOperation was received, later on this is discarded, but we can avoid generating data that is dropped.

Test Plan

No data generated when DMOperation is received.
Notifs works

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Thu, Sep 19, 6:14 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Sep 19, 6:14 AM

kamil published this revision for review.Thu, Sep 19, 6:21 AM

Harbormaster completed remote builds in B31716: Diff 44346.Thu, Sep 19, 6:32 AM

tomek accepted this revision.Fri, Sep 20, 2:24 AM

This revision is now accepted and ready to land.Fri, Sep 20, 2:24 AM

rebase

Harbormaster completed remote builds in B31750: Diff 44388.Fri, Sep 20, 7:41 AM

Closed by commit rCOMM2b686b3c4b7b: [lib] avoid creating `notificationsCreationData` on `DMOperation` received from… (authored by kamil). · Explain WhyFri, Sep 20, 7:48 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM2b686b3c4b7b: [lib] avoid creating `notificationsCreationData` on `DMOperation` received from….

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

process-dm-ops.js

23 lines

Diff 44392

View Options

lib/shared/dm-ops/process-dm-ops.js

[lib] avoid creating `notificationsCreationData` on `DMOperation` received from other peerClosedPublicActions