Page MenuHomePhabricator
Differential D13430

[native] Improve logging for thick threads notifs
ClosedPublic
Actions

Authored by ashoat on Mon, Sep 23, 10:14 PM.
Tags
None
Referenced Files
F2846677: D13430.id44453.diff
Sun, Sep 29, 11:30 PM
F2845490: D13430.diff
Sun, Sep 29, 9:29 PM
F2839959: D13430.diff
Sun, Sep 29, 4:00 AM
F2839368: D13430.diff
Sun, Sep 29, 1:46 AM
Unknown Object (File)
Sat, Sep 28, 1:00 AM
Unknown Object (File)
Wed, Sep 25, 1:29 AM
Unknown Object (File)
Wed, Sep 25, 1:29 AM
Unknown Object (File)
Wed, Sep 25, 1:01 AM
Subscribers
tomek

Details

Reviewers
marcin
Commits
rCOMM7eea1cd5e976: [native] Improve logging for thick threads notifs
Summary

I found these logging improvements helpful while investigating ENG-9233. I'll annotate each inline.

Test Plan

Confirmed logging improvements

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mon, Sep 23, 10:14 PM
Herald added a subscriber: tomek. · View Herald TranscriptMon, Sep 23, 10:14 PM
ashoat added a child revision: D13431: [native] Avoid Promise.allSettled.Mon, Sep 23, 10:16 PM
ashoat added inline comments.Mon, Sep 23, 10:22 PM
lib/push/crypto.js
192

Before:

Notification encryption failed: [object Object]

After:

Notification encryption failed {"message": "Session with deviceID: tjiSvK/6Z1aebjrLb55mpzWoIiN4Lr3yndNvNYw7ySo not initialized."}
lib/push/send-utils.js
1001

Before:

[TypeError: undefined is not a function]

After:

Olm session creation failed [TypeError: undefined is not a function]
Harbormaster completed remote builds in B31787: Diff 44453.Mon, Sep 23, 10:31 PM
ashoat requested review of this revision.Mon, Sep 23, 10:31 PM
marcin accepted this revision.Tue, Sep 24, 9:16 AM
This revision is now accepted and ready to land.Tue, Sep 24, 9:16 AM
Closed by commit rCOMM7eea1cd5e976: [native] Improve logging for thick threads notifs (authored by ashoat). · Explain WhyTue, Sep 24, 3:04 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM7eea1cd5e976: [native] Improve logging for thick threads notifs.

Revision Contents
Changeset List

PathSize
lib/
push/
8 lines
2 lines

Diff 44453

View Options

lib/push/crypto.js

Loading...
View Options

lib/push/send-utils.js

Loading...