Page MenuHomePhabricator
Differential D13430

[native] Improve logging for thick threads notifs
ClosedPublic
Actions

Authored by ashoat on Sep 23 2024, 10:14 PM.
Tags
None
Referenced Files
F3643930: D13430.id44504.diff
Sat, Jan 4, 6:16 PM
F3643929: D13430.id44453.diff
Sat, Jan 4, 6:16 PM
F3643911: D13430.id.diff
Sat, Jan 4, 6:15 PM
F3643900: D13430.diff
Sat, Jan 4, 6:15 PM
Unknown Object (File)
Thu, Jan 2, 2:43 PM
Unknown Object (File)
Sun, Dec 22, 10:33 AM
Unknown Object (File)
Dec 5 2024, 7:50 PM
Unknown Object (File)
Dec 5 2024, 7:44 PM
View All 37 Files
Subscribers
tomek

Details

Reviewers
marcin
Commits
rCOMM7eea1cd5e976: [native] Improve logging for thick threads notifs
Summary

I found these logging improvements helpful while investigating ENG-9233. I'll annotate each inline.

Test Plan

Confirmed logging improvements

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 23 2024, 10:14 PM
Herald added a subscriber: tomek. · View Herald TranscriptSep 23 2024, 10:14 PM
ashoat added a child revision: D13431: [native] Avoid Promise.allSettled.Sep 23 2024, 10:16 PM
ashoat added inline comments.Sep 23 2024, 10:22 PM
lib/push/crypto.js
192 ↗(On Diff #44453)

Before:

Notification encryption failed: [object Object]

After:

Notification encryption failed {"message": "Session with deviceID: tjiSvK/6Z1aebjrLb55mpzWoIiN4Lr3yndNvNYw7ySo not initialized."}
lib/push/send-utils.js
1001 ↗(On Diff #44453)

Before:

[TypeError: undefined is not a function]

After:

Olm session creation failed [TypeError: undefined is not a function]
Harbormaster completed remote builds in B31787: Diff 44453.Sep 23 2024, 10:31 PM
ashoat requested review of this revision.Sep 23 2024, 10:31 PM
marcin accepted this revision.Sep 24 2024, 9:16 AM
This revision is now accepted and ready to land.Sep 24 2024, 9:16 AM
Closed by commit rCOMM7eea1cd5e976: [native] Improve logging for thick threads notifs (authored by ashoat). · Explain WhySep 24 2024, 3:04 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM7eea1cd5e976: [native] Improve logging for thick threads notifs.

Revision Contents
Changeset List

PathSize
lib/
push/
8 lines
2 lines

Diff 44504

View Options

lib/push/crypto.js

Loading...
View Options

lib/push/send-utils.js

Loading...