Page MenuHomePhabricator
Differential D13449

[web][native] fix relationship buttons in thread settings
ClosedPublic
Actions

Authored by kamil on Tue, Sep 24, 7:02 AM.
Tags
None
Referenced Files
F2844530: D13449.diff
Sun, Sep 29, 7:36 PM
F2838873: D13449.diff
Sun, Sep 29, 12:01 AM
Unknown Object (File)
Sat, Sep 28, 4:35 PM
Unknown Object (File)
Wed, Sep 25, 12:40 PM
Unknown Object (File)
Wed, Sep 25, 12:40 PM
Subscribers
None

Details

Reviewers
tomek
ashoat
Commits
rCOMMd788f39fa013: [web][native] fix relationship buttons in thread settings
Summary

ENG-9320.

  1. Fixing rendering relationship tab on web condition.
  2. Updating check on native to support thick threads.
Test Plan

Buttons visible only on personal threads.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Tue, Sep 24, 7:02 AM
kamil held this revision as a draft.
kamil published this revision for review.Tue, Sep 24, 7:02 AM
tomek accepted this revision.Tue, Sep 24, 7:13 AM
tomek added inline comments.
web/modals/threads/settings/thread-settings-modal.react.js
105 ↗(On Diff #44485)
This revision is now accepted and ready to land.Tue, Sep 24, 7:13 AM
Harbormaster completed remote builds in B31817: Diff 44485.Tue, Sep 24, 7:20 AM
kamil added inline comments.Wed, Sep 25, 5:37 AM
web/modals/threads/settings/thread-settings-modal.react.js
105 ↗(On Diff #44485)

we need entire threadInfo

kamil updated this revision to Diff 44529.Wed, Sep 25, 5:40 AM

address review

Harbormaster completed remote builds in B31841: Diff 44529.Wed, Sep 25, 5:58 AM
Closed by commit rCOMMd788f39fa013: [web][native] fix relationship buttons in thread settings (authored by kamil). · Explain WhyWed, Sep 25, 6:00 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMd788f39fa013: [web][native] fix relationship buttons in thread settings.

Revision Contents
Changeset List

PathSize
lib/
types/
9 lines
native/
chat/
settings/
6 lines
web/
modals/
threads/
settings/
13 lines

Diff 44538

View Options

lib/types/thread-types-enum.js

Loading...
View Options

native/chat/settings/thread-settings.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-modal.react.js

Loading...