Page MenuHomePhabricator

[lib] fix `useThreadSearchIndex` to avoid ignoring private thread
ClosedPublic

Authored by kamil on Sep 25 2024, 6:11 AM.
Tags
None
Referenced Files
F3299731: D13461.id44540.diff
Sun, Nov 17, 3:06 PM
Unknown Object (File)
Fri, Nov 1, 2:14 PM
Unknown Object (File)
Fri, Nov 1, 2:14 PM
Unknown Object (File)
Fri, Nov 1, 2:14 PM
Unknown Object (File)
Fri, Nov 1, 2:14 PM
Unknown Object (File)
Wed, Oct 30, 10:19 PM
Unknown Object (File)
Sat, Oct 19, 11:07 PM
Unknown Object (File)
Oct 16 2024, 9:34 AM
Subscribers
None

Details

Summary

ENG-9378.

This code was ignoring private threads and as a result, causing that private thread not to show up.
On prod, it works only for old users where by default thread name was the user's name, after changing the name in settings it is not working anymore. Right now, when creating an account name is not set for the private thread, it's an optional field and not set to own username - that is why this is not working for dev where we have new users.

Test Plan

Searching for my username works (even if I changed name of my private thread).

Diff Detail

Repository
rCOMM Comm
Branch
fix-searching
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Sep 25 2024, 6:12 AM
kamil edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 25 2024, 6:30 AM

You're right – my PRIVATE thread is named "ashoat", which explains why it was working for me