Page MenuHomePhabricator
Differential D13487

[lib] fix thick thread showing multiple times in thread list
ClosedPublic
Actions

Authored by kamil on Sep 26 2024, 3:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 7:21 PM
Unknown Object (File)
Wed, Dec 18, 7:21 PM
Unknown Object (File)
Wed, Dec 18, 7:21 PM
Unknown Object (File)
Wed, Dec 18, 7:21 PM
Unknown Object (File)
Wed, Dec 18, 7:21 PM
Unknown Object (File)
Nov 16 2024, 4:53 AM
Unknown Object (File)
Nov 16 2024, 2:05 AM
Unknown Object (File)
Nov 15 2024, 11:35 PM
View All 46 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMf1a29a5027cc: [lib] fix thick thread showing multiple times in thread list
Summary

ENG-9394

Test Plan

Search for users which has a personal thick thread and should show up only once

Diff Detail

Repository
rCOMM Comm
Branch
land
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Sep 26 2024, 3:49 AM
kamil held this revision as a draft.
kamil added a child revision: D13488: [lib] rename `userSupportsThickThreads` -> `userHasDeviceList`.Sep 26 2024, 3:54 AM
kamil added a parent revision: D13486: [lib] implement fetching missing peers when generating P2P messages.Sep 26 2024, 4:00 AM
Harbormaster completed remote builds in B31877: Diff 44595.Sep 26 2024, 4:06 AM
kamil published this revision for review.Sep 26 2024, 4:22 AM
ashoat accepted this revision.Sep 26 2024, 7:54 AM
This revision is now accepted and ready to land.Sep 26 2024, 7:54 AM
ashoat added inline comments.Sep 27 2024, 9:00 AM
lib/selectors/user-selectors.js
186–187 ↗(On Diff #44595)

Instead of this, can we actually use threadTypeIsPersonal? I'd like to be able to git grep GENESIS_PERSONAL and only get results that are specific to GENESIS_PERSONAL

kamil added inline comments.Sep 30 2024, 4:44 AM
lib/selectors/user-selectors.js
186–187 ↗(On Diff #44595)

good call

kamil updated this revision to Diff 44672.Sep 30 2024, 4:45 AM

use threadTypeIsPersonal

This revision was landed with ongoing or failed builds.Sep 30 2024, 4:58 AM
Closed by commit rCOMMf1a29a5027cc: [lib] fix thick thread showing multiple times in thread list (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMf1a29a5027cc: [lib] fix thick thread showing multiple times in thread list.
Harbormaster completed remote builds in B31927: Diff 44672.Sep 30 2024, 5:06 AM

Revision Contents
Changeset List

PathSize
lib/
selectors/
4 lines

Diff 44672

View Options

lib/selectors/user-selectors.js

Loading...