Page MenuHomePhabricator
Differential D13530

[lib] use v2 relevant followers API to find farcaster friends
ClosedPublic
Actions

Authored by varun on Sep 30 2024, 3:41 PM.
Tags
None
Referenced Files
F3358201: D13530.id44702.diff
Sun, Nov 24, 3:38 AM
Unknown Object (File)
Fri, Nov 1, 4:23 PM
Unknown Object (File)
Fri, Nov 1, 4:22 PM
Unknown Object (File)
Fri, Nov 1, 4:22 PM
Unknown Object (File)
Fri, Nov 1, 4:21 PM
Unknown Object (File)
Fri, Nov 1, 5:35 AM
Unknown Object (File)
Oct 24 2024, 12:18 PM
Unknown Object (File)
Oct 23 2024, 6:18 AM
View All 33 Files
Subscribers
tomek

Details

Reviewers
ashoat
will
Commits
rCOMM288f98412b1a: [lib] use v2 relevant followers API to find farcaster friends
Summary

this API returns what we want -- farcaster mutuals. and it seems to work pretty consistently, unlike the paginated v1 followers API.

Test Plan

successfully got back farcaster mutuals for dwr.eth (fid 3), who has a ton of followers

Diff Detail

Repository
rCOMM Comm
Branch
0.38-deployment
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Sep 30 2024, 3:41 PM
Herald added a subscriber: tomek. · View Herald TranscriptSep 30 2024, 3:41 PM
varun added a comment.Sep 30 2024, 3:48 PM

also confirmed that threads are created with farcaster mutuals who are also on comm

varun published this revision for review.Sep 30 2024, 3:56 PM
will accepted this revision.Sep 30 2024, 3:59 PM
This revision is now accepted and ready to land.Sep 30 2024, 3:59 PM
Harbormaster completed remote builds in B31945: Diff 44702.Sep 30 2024, 4:00 PM
ashoat requested changes to this revision.Sep 30 2024, 4:42 PM
ashoat added inline comments.
lib/utils/neynar-client.js
10–11

Read-only

74–75

How could this possibly work if you're not taking the viewer's FID into account?

This revision now requires changes to proceed.Sep 30 2024, 4:42 PM
ashoat accepted this revision.Sep 30 2024, 4:43 PM

Never mind, sorry – the viewer's FID is the only input taken

lib/utils/neynar-client.js
74–75

Oops sorry

This revision is now accepted and ready to land.Sep 30 2024, 4:43 PM
ashoat added a comment.Sep 30 2024, 4:43 PM

(Please make read-only before landing)

Closed by commit rCOMM288f98412b1a: [lib] use v2 relevant followers API to find farcaster friends (authored by varun). · Explain WhySep 30 2024, 5:37 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM288f98412b1a: [lib] use v2 relevant followers API to find farcaster friends.

Revision Contents
Changeset List

PathSize
lib/
utils/
86 lines

Diff 44702

View Options

lib/utils/neynar-client.js

Loading...