[native] Combine invokeAsync calls at the end of initializeCryptoAccount
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 12:13 PM.

Details

Reviewers

varun
will

Commits

rCOMM8f8315d83c03: [native] Combine invokeAsync calls at the end of initializeCryptoAccount

Summary

I think these were accidentally split up in D11232. In the first revision of that diff, it made sense to separate them. By the final revision, it no longer made sense, but the split was left there.

Depends on D13526

Test Plan

Confirm that the app builds and that initializeCryptoAccount still executes successfully

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 30 2024, 12:13 PM

Herald added a subscriber: tomek. · View Herald TranscriptSep 30 2024, 12:13 PM

Harbormaster completed remote builds in B31942: Diff 44699.Sep 30 2024, 12:31 PM

ashoat requested review of this revision.Sep 30 2024, 12:31 PM

will accepted this revision.Sep 30 2024, 3:32 PM

This revision is now accepted and ready to land.Sep 30 2024, 3:32 PM

Closed by commit rCOMM8f8315d83c03: [native] Combine invokeAsync calls at the end of initializeCryptoAccount (authored by ashoat). · Explain WhySep 30 2024, 4:49 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8f8315d83c03: [native] Combine invokeAsync calls at the end of initializeCryptoAccount.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

4 lines

Diff 44708

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

[native] Combine invokeAsync calls at the end of initializeCryptoAccountClosedPublicActions