Paths

Table of Contentst

Differential D13583

[lib] Batch BaseAutoJoinCommunityHandler
ClosedPublic
Actions

Authored by ashoat on Oct 2 2024, 11:58 PM.

Tags

None

Referenced Files

	F3401143: D13583.id44849.diff
	Mon, Dec 2, 10:44 AM

	F3400984: D13583.id44851.diff
	Mon, Dec 2, 9:56 AM

	F3400503: D13583.id44850.diff
	Mon, Dec 2, 7:29 AM

	Unknown Object (File)
	Tue, Nov 26, 4:19 AM

	Unknown Object (File)
	Sat, Nov 23, 6:27 AM

	Unknown Object (File)
	Sun, Nov 10, 11:46 AM

	Unknown Object (File)
	Sun, Nov 10, 10:07 AM

	Unknown Object (File)
	Sun, Nov 10, 6:26 AM

View All 42 Files

Subscribers

Details

Reviewers

varun
will

Commits

rCOMM4c5fc7883f77: [lib] Batch BaseAutoJoinCommunityHandler

Summary

This diff updates BaseAutoJoinCommunityHandler to work in batches of 5, and to avoid triggering a joinCommunity for a single community more than once.

Test Plan

Varun tested this in his local environment, where he has set up a reproduction of the production environment where we have a lot of communities tagged with Farcaster channels, and he tested signing in as a user with a lot of channels

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 2 2024, 11:58 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 2 2024, 11:58 PM

Harbormaster completed remote builds in B32032: Diff 44849.Oct 3 2024, 12:15 AM

ashoat requested review of this revision.Oct 3 2024, 12:15 AM

not reviewing too closely because it's late

This revision is now accepted and ready to land.Oct 3 2024, 12:32 AM

Add sleep(1000) before joinCommunity. Testing on prod this avoided the lag issue

This revision was landed with ongoing or failed builds.Oct 3 2024, 12:41 AM

Closed by commit rCOMM4c5fc7883f77: [lib] Batch BaseAutoJoinCommunityHandler (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM4c5fc7883f77: [lib] Batch BaseAutoJoinCommunityHandler.

Harbormaster completed remote builds in B32033: Diff 44850.Oct 3 2024, 12:57 AM

Revision Contents
Changeset List

Path

Size

lib/

components/

base-auto-join-community-handler.react.js

175 lines

Diff 44851

lib/components/base-auto-join-community-handler.react.js

Loading...