[lib] Make Blob service facts types more strict
ClosedPublic
Actions

Authored by bartek on Oct 10 2024, 9:33 PM.

Details

Reviewers

ashoat
kamil

Commits

rCOMMde679c3c4910: [lib] Make Blob service facts types more strict

Summary

Part of ENG-9422 about making types more strict.
Helps to avoid issues like ENG-9584.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Oct 10 2024, 9:33 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 10 2024, 9:33 PM

Harbormaster completed remote builds in B32195: Diff 45091.Oct 10 2024, 9:51 PM

bartek requested review of this revision.Oct 10 2024, 9:51 PM

ashoat accepted this revision.Oct 11 2024, 12:59 AM

ashoat added inline comments.

lib/facts/blob-service.js
6–11 ↗	(On Diff #45091)
14–15 ↗	(On Diff #45091)	Interesting, I didn't know about this format

This revision is now accepted and ready to land.Oct 11 2024, 12:59 AM

bartek added inline comments.Oct 14 2024, 6:15 AM

lib/facts/blob-service.js
14–15 ↗	(On Diff #45091)	Me neither but I found it in the docs https://flow.org/en/docs/types/indexed-access/

Readonly

Harbormaster completed remote builds in B32218: Diff 45134.Oct 14 2024, 6:32 AM

Closed by commit rCOMMde679c3c4910: [lib] Make Blob service facts types more strict. · Explain WhyOct 14 2024, 8:07 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMde679c3c4910: [lib] Make Blob service facts types more strict.

Revision Contents
Changeset List

Path

Size

lib/

facts/

blob-service.js

17 lines

Diff 45134

View Options

[lib] Make Blob service facts types more strictClosedPublicActions