[lib] Make Blob service facts types more strict
ClosedPublic
Actions

Authored by bartek on Thu, Oct 10, 2:33 PM.

Tags

None

Referenced Files

	F2986899: D13696.id45134.diff
	Wed, Oct 16, 2:27 PM

	F2986497: D13696.id45136.diff
	Wed, Oct 16, 2:03 PM

	F2986489: D13696.id45091.diff
	Wed, Oct 16, 1:58 PM

	F2984016: D13696.diff
	Wed, Oct 16, 11:52 AM

	Unknown Object (File)
	Tue, Oct 15, 9:58 AM

	Unknown Object (File)
	Sun, Oct 13, 3:27 PM

	Unknown Object (File)
	Sat, Oct 12, 6:49 AM

	Unknown Object (File)
	Sat, Oct 12, 6:06 AM

View All 15 Files

Subscribers

tomek

Details

Reviewers

ashoat
kamil

Commits

rCOMMde679c3c4910: [lib] Make Blob service facts types more strict

Summary

Part of ENG-9422 about making types more strict.
Helps to avoid issues like ENG-9584.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Thu, Oct 10, 2:33 PM

Herald added a subscriber: tomek. · View Herald TranscriptThu, Oct 10, 2:33 PM

Harbormaster completed remote builds in B32195: Diff 45091.Thu, Oct 10, 2:51 PM

bartek requested review of this revision.Thu, Oct 10, 2:51 PM

ashoat accepted this revision.Thu, Oct 10, 5:59 PM

ashoat added inline comments.

lib/facts/blob-service.js
6–11 ↗	(On Diff #45091)
14–15 ↗	(On Diff #45091)	Interesting, I didn't know about this format

This revision is now accepted and ready to land.Thu, Oct 10, 5:59 PM

bartek added inline comments.Sun, Oct 13, 11:15 PM

lib/facts/blob-service.js
14–15 ↗	(On Diff #45091)	Me neither but I found it in the docs https://flow.org/en/docs/types/indexed-access/

Readonly

Harbormaster completed remote builds in B32218: Diff 45134.Sun, Oct 13, 11:32 PM

Closed by commit rCOMMde679c3c4910: [lib] Make Blob service facts types more strict (authored by bartek). · Explain WhyMon, Oct 14, 1:07 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMde679c3c4910: [lib] Make Blob service facts types more strict.

Revision Contents
Changeset List

Path

Size

lib/

facts/

blob-service.js

17 lines

Diff 45136

View Options

[lib] Make Blob service facts types more strictClosedPublicActions