Paths

Table of Contentst

Differential D13710

[native][web] Fix ENS resolution for local DM notifs
ClosedPublic
Actions

Authored by ashoat on Oct 14 2024, 8:24 PM.

Tags

None

Referenced Files

	F3518541: D13710.id45184.diff
	Sun, Dec 22, 8:17 PM

	F3518536: D13710.diff
	Sun, Dec 22, 8:14 PM

	Unknown Object (File)
	Fri, Dec 20, 3:44 PM

	Unknown Object (File)
	Wed, Dec 18, 2:19 PM

	Unknown Object (File)
	Wed, Dec 18, 8:39 AM

	Unknown Object (File)
	Wed, Dec 18, 8:39 AM

	Unknown Object (File)
	Wed, Dec 18, 8:39 AM

	Unknown Object (File)
	Wed, Dec 18, 8:38 AM

View All 53 Files

Subscribers

None

Details

Reviewers

tomek
kamil
angelika

Commits

rCOMM03a6c519bfc5: [native][web] Fix ENS resolution for local DM notifs

Summary

ENSCacheProvider and NeynarClientProvider are relatively standalone components, and can safely be rendered higher in the tree.

On the other hand, TunnelbrokerProvider now handles notif sending, and as such is tightly coupled with business logic. We should render it lower in the hierarchy.

This diff solves ENG-9641 by making sure the DM notif-sending code in TunnelbrokerProvider is able to access the ENSCache in ENSCacheProvider, and the Farcaster username resolving code in NeynarClientProvider.

Test Plan

Confirmed that ENS resolution was working again for local DM notifs

Diff Detail

Repository

Branch

ashoat/basenames

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 14 2024, 8:24 PM

ashoat added a comment.Oct 14 2024, 8:25 PM

This comment was removed by ashoat.

Going to land this one without review as it resolves an urgent issue

ashoat edited the summary of this revision. (Show Details)Oct 14 2024, 8:26 PM

Rebase

This revision was not accepted when it landed; it landed in state Needs Review.Oct 14 2024, 8:38 PM

This revision was landed with ongoing or failed builds.

Closed by commit rCOMM03a6c519bfc5: [native][web] Fix ENS resolution for local DM notifs (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM03a6c519bfc5: [native][web] Fix ENS resolution for local DM notifs.

Harbormaster completed remote builds in B32245: Diff 45184.Oct 14 2024, 8:45 PM

Harbormaster completed remote builds in B32247: Diff 45186.Oct 14 2024, 9:03 PM

Revision Contents
Changeset List

Path

Size

native/

76 lines

web/

110 lines

Diff 45186

native/root.react.js

Loading...

web/app.react.js

Loading...