Page MenuHomePhabricator

[native][web] Fix ENS resolution for local DM notifs
ClosedPublic

Authored by ashoat on Oct 14 2024, 8:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 16, 10:48 AM
Unknown Object (File)
Sat, Nov 16, 10:48 AM
Unknown Object (File)
Sat, Nov 16, 10:48 AM
Unknown Object (File)
Sat, Nov 16, 10:47 AM
Unknown Object (File)
Sat, Nov 16, 10:47 AM
Unknown Object (File)
Mon, Nov 11, 4:18 AM
Unknown Object (File)
Sun, Nov 10, 6:46 PM
Unknown Object (File)
Sun, Nov 10, 4:47 PM
Subscribers
None

Details

Summary

ENSCacheProvider and NeynarClientProvider are relatively standalone components, and can safely be rendered higher in the tree.

On the other hand, TunnelbrokerProvider now handles notif sending, and as such is tightly coupled with business logic. We should render it lower in the hierarchy.

This diff solves ENG-9641 by making sure the DM notif-sending code in TunnelbrokerProvider is able to access the ENSCache in ENSCacheProvider, and the Farcaster username resolving code in NeynarClientProvider.

Test Plan

Confirmed that ENS resolution was working again for local DM notifs

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/basenames
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

This comment was removed by ashoat.
ashoat published this revision for review.Oct 14 2024, 8:25 PM

Going to land this one without review as it resolves an urgent issue

This revision was not accepted when it landed; it landed in state Needs Review.Oct 14 2024, 8:38 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.