Paths

Table of Contentst

[native][web] Fix robotext thread creation
ClosedPublic
Actions

Authored by ashoat on Mon, Oct 14, 9:34 AM.

Tags

None

Referenced Files

	F2982744: D13707.id45176.diff
	Wed, Oct 16, 5:20 AM

	F2982743: D13707.id45196.diff
	Wed, Oct 16, 5:19 AM

	F2982395: D13707.diff
	Wed, Oct 16, 3:25 AM

	Unknown Object (File)
	Tue, Oct 15, 4:16 AM

	Unknown Object (File)
	Tue, Oct 15, 4:14 AM

	Unknown Object (File)
	Tue, Oct 15, 3:37 AM

	Unknown Object (File)
	Tue, Oct 15, 3:15 AM

	Unknown Object (File)
	Tue, Oct 15, 3:12 AM

View All 10 Files

Subscribers

None

Details

Reviewers

tomek
angelika
kamil

Commits

rCOMM969bbbe7264e: [native][web] Fix robotext thread creation

Summary

This addresses ENG-9636. I failed to consider some cases where we need to use chatMessageItemEngagementTargetMessageInfo now.

Test Plan

I tested in my local environment and confirmed the issue no longer appeared for both web and native

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mon, Oct 14, 9:34 AM

Harbormaster completed remote builds in B32238: Diff 45176.Mon, Oct 14, 9:52 AM

ashoat requested review of this revision.Mon, Oct 14, 9:52 AM

ashoat added a child revision: D13708: [web] Fix reacting to robotext.Mon, Oct 14, 11:44 AM

kamil accepted this revision.Tue, Oct 15, 1:10 AM

This revision is now accepted and ready to land.Tue, Oct 15, 1:10 AM

Closed by commit rCOMM969bbbe7264e: [native][web] Fix robotext thread creation (authored by ashoat). · Explain WhyTue, Oct 15, 5:46 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM969bbbe7264e: [native][web] Fix robotext thread creation.

Revision Contents
Changeset List

Path

Size

native/

chat/

sidebar-navigation.js

10 lines

web/

tooltips/

tooltip-action-utils.js

3 lines

Diff 45196

View Options

native/chat/sidebar-navigation.js