Paths

Table of Contentst

[native][web] Fix robotext thread creation
ClosedPublic
Actions

Authored by ashoat on Oct 14 2024, 9:34 AM.

Tags

None

Referenced Files

	F3520813: D13707.id45196.diff
	Mon, Dec 23, 1:26 AM

	F3518867: D13707.id45176.diff
	Sun, Dec 22, 8:52 PM

	Unknown Object (File)
	Wed, Dec 18, 8:39 AM

	Unknown Object (File)
	Wed, Dec 18, 8:39 AM

	Unknown Object (File)
	Wed, Dec 18, 8:38 AM

	Unknown Object (File)
	Wed, Dec 18, 8:36 AM

	Unknown Object (File)
	Sun, Dec 15, 8:07 PM

	Unknown Object (File)
	Sun, Dec 15, 3:05 AM

View All 56 Files

Subscribers

None

Details

Reviewers

tomek
angelika
kamil

Commits

rCOMM969bbbe7264e: [native][web] Fix robotext thread creation

Summary

This addresses ENG-9636. I failed to consider some cases where we need to use chatMessageItemEngagementTargetMessageInfo now.

Test Plan

I tested in my local environment and confirmed the issue no longer appeared for both web and native

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 14 2024, 9:34 AM

Harbormaster completed remote builds in B32238: Diff 45176.Oct 14 2024, 9:52 AM

ashoat requested review of this revision.Oct 14 2024, 9:52 AM

ashoat added a child revision: D13708: [web] Fix reacting to robotext.Oct 14 2024, 11:44 AM

kamil accepted this revision.Oct 15 2024, 1:10 AM

This revision is now accepted and ready to land.Oct 15 2024, 1:10 AM

Closed by commit rCOMM969bbbe7264e: [native][web] Fix robotext thread creation (authored by ashoat). · Explain WhyOct 15 2024, 5:46 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM969bbbe7264e: [native][web] Fix robotext thread creation.

Revision Contents
Changeset List

Path

Size

native/

chat/

sidebar-navigation.js

10 lines

web/

tooltips/

tooltip-action-utils.js

3 lines

Diff 45196

View Options

native/chat/sidebar-navigation.js