Page MenuHomePhabricator
Differential D13721

[lib/native/web] Enable option to save notif tab of child threads irregardless of parent setting or sidebar type on web and native
ClosedPublic
Actions

Authored by will on Oct 15 2024, 2:59 PM.
Tags
None
Referenced Files
F3340595: D13721.id45279.diff
Thu, Nov 21, 10:05 PM
F3339870: D13721.id45213.diff
Thu, Nov 21, 8:55 PM
F3337142: D13721.diff
Thu, Nov 21, 3:44 PM
Unknown Object (File)
Wed, Nov 20, 8:56 AM
Unknown Object (File)
Wed, Nov 20, 8:56 AM
Unknown Object (File)
Wed, Nov 20, 8:56 AM
Unknown Object (File)
Wed, Nov 20, 8:56 AM
Unknown Object (File)
Fri, Nov 15, 11:08 PM
View All 32 Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMM4a37abc720ff: [lib/native/web] Enable option to save notif tab of child threads irregardless…
Summary

This allows sidebars to be moved to separate tabs from their parents. Radio buttons are enabled irregardless of sidebar type. Save buttons are enabled even if parents are muted

Notice texts are also removed

Depends on D13719

Test Plan

Tested on both web and native (iOS simulator), ensuring that child threads could be moved separate from their parents by selecting the mute/home radio buttons and clicking save

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Oct 15 2024, 2:59 PM
Herald added a subscriber: tomek. · View Herald TranscriptOct 15 2024, 2:59 PM
Harbormaster completed remote builds in B32261: Diff 45213.Oct 15 2024, 3:39 PM
will requested review of this revision.Oct 15 2024, 3:39 PM
ashoat requested changes to this revision.Oct 16 2024, 10:10 AM
ashoat added inline comments.
native/chat/settings/thread-settings-notifications.react.js
152–162

What is the point of setting this in an effect?

This revision now requires changes to proceed.Oct 16 2024, 10:10 AM
ashoat accepted this revision.Oct 16 2024, 10:50 AM
ashoat added inline comments.
native/chat/settings/thread-settings-notifications.react.js
152–162

Never mind about this... we need onSave and saveButtonDisabled, so this makes sense

This revision is now accepted and ready to land.Oct 16 2024, 10:50 AM
will edited the summary of this revision. (Show Details)Oct 16 2024, 11:18 AM
will added a parent revision: D13719: [lib] Show sidebars in top level if parent thread is in a separate tab.
will removed a parent revision: D13720: [lib] Do not show sidebar underneath parent if in different tab.
Closed by commit rCOMM4a37abc720ff: [lib/native/web] Enable option to save notif tab of child threads irregardless… (authored by will). · Explain WhyOct 18 2024, 9:36 AM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM4a37abc720ff: [lib/native/web] Enable option to save notif tab of child threads irregardless….

Revision Contents
Changeset List

PathSize
lib/
shared/
26 lines
native/
chat/
settings/
79 lines
web/
modals/
threads/
notifications/
55 lines

Diff 45213

View Options

lib/shared/thread-settings-notifications-utils.js

Loading...
View Options

native/chat/settings/thread-settings-notifications.react.js

Loading...
View Options

web/modals/threads/notifications/notifications-modal.react.js

Loading...