[web] Memoize result of calling getThreadListSearchResults
ClosedPublic
Actions

Authored by ashoat on Oct 16 2024, 10:31 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 22, 10:23 PM

	Unknown Object (File)
	Sun, Dec 22, 10:23 PM

	Unknown Object (File)
	Sun, Dec 22, 10:23 PM

	Unknown Object (File)
	Sun, Dec 22, 10:23 PM

	Unknown Object (File)
	Nov 25 2024, 12:18 PM

	Unknown Object (File)
	Nov 20 2024, 8:17 AM

	Unknown Object (File)
	Nov 20 2024, 8:17 AM

	Unknown Object (File)
	Nov 20 2024, 8:17 AM

View All 39 Files

Subscribers

tomek

Details

Reviewers

will

Commits

rCOMM0ac8fb284236: [web] Memoize result of calling getThreadListSearchResults

Summary

We are currently recalculating the thread list on every single render.

Test Plan

Flow – this change is simple and safe

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/memo

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 16 2024, 10:31 AM

Herald added a subscriber: tomek. · View Herald TranscriptOct 16 2024, 10:31 AM

Harbormaster completed remote builds in B32273: Diff 45229.Oct 16 2024, 10:50 AM

ashoat requested review of this revision.Oct 16 2024, 10:50 AM

will accepted this revision.Oct 16 2024, 11:02 AM

This revision is now accepted and ready to land.Oct 16 2024, 11:02 AM

Closed by commit rCOMM0ac8fb284236: [web] Memoize result of calling getThreadListSearchResults (authored by ashoat). · Explain WhyOct 16 2024, 11:22 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM0ac8fb284236: [web] Memoize result of calling getThreadListSearchResults.

Revision Contents
Changeset List

Path

Size

web/

chat/

thread-list-provider.js

25 lines

Diff 45229

View Options

web/chat/thread-list-provider.js

[web] Memoize result of calling getThreadListSearchResultsClosedPublicActions