Page MenuHomePhabricator
Differential D13731

[keyserver] Also delete from ids table when deleting invite links
ClosedPublic
Actions

Authored by ashoat on Oct 16 2024, 12:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 4:58 AM
Unknown Object (File)
Thu, Nov 14, 3:02 PM
Unknown Object (File)
Thu, Nov 14, 2:56 PM
Unknown Object (File)
Thu, Nov 14, 12:55 PM
Unknown Object (File)
Thu, Nov 7, 8:52 AM
Unknown Object (File)
Thu, Nov 7, 2:05 AM
Unknown Object (File)
Thu, Nov 7, 2:02 AM
Unknown Object (File)
Wed, Nov 6, 11:59 PM
View All 60 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMM434d919a439c: [keyserver] Also delete from ids table when deleting invite links
Summary

Noticed this query wasn't deleting from the ids table. Turns out that the RETURNING keyword isn't allowed for multi-table deletes, so I had to rework the logic.

Test Plan
  1. I deleted an invite link from the UI and confirmed it was removed from MariaDB and DynamoDB
  2. I tested in combination with the next diff, where I introduce a cronjob for deleting orphaned invite links

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 16 2024, 12:42 PM
ashoat added a child revision: D13732: [keyserver] Add cron to delete orphaned invite links.Oct 16 2024, 12:44 PM
Harbormaster completed remote builds in B32274: Diff 45231.Oct 16 2024, 1:00 PM
ashoat requested review of this revision.Oct 16 2024, 1:00 PM
ashoat updated this revision to Diff 45233.Oct 16 2024, 1:52 PM

Format

Harbormaster failed remote builds in B32276: Diff 45233!Oct 16 2024, 1:56 PM
Harbormaster completed remote builds in B32276: Diff 45233.Oct 16 2024, 2:44 PM
ashoat updated this revision to Diff 45235.Oct 16 2024, 8:42 PM

Don't do anything if links array is empty

Harbormaster completed remote builds in B32278: Diff 45235.Oct 16 2024, 9:01 PM
tomek accepted this revision.Oct 17 2024, 1:48 AM
This revision is now accepted and ready to land.Oct 17 2024, 1:48 AM
Closed by commit rCOMM434d919a439c: [keyserver] Also delete from ids table when deleting invite links (authored by ashoat). · Explain WhyOct 17 2024, 6:57 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM434d919a439c: [keyserver] Also delete from ids table when deleting invite links.

Revision Contents
Changeset List

PathSize
keyserver/
src/
deleters/
52 lines

Diff 45233

View Options

keyserver/src/deleters/link-deleters.js

Loading...