[lib] use fc channel avatar url in useResolvedThreadAvatar
Needs ReviewPublic
Actions

Authored by varun on Thu, Oct 17, 5:50 AM.

Details

Reviewers

Summary

Depends on D13743

useResolvedThreadAvatar can take an object containing a username and FID or an object containing a farcaster channel ID.

the former is when we want to display a user avatar as the thread avatar

we want these types to be mutually exclusive to avoid confusion when the avatar type is 'farcaster' and the function caller provides a farcaster channel ID and a user FID

Test Plan

tested in next diffs by successfully rendering farcaster channel images as thread avatars

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Thu, Oct 17, 5:50 AM

varun held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptThu, Oct 17, 5:50 AM

varun added a child revision: D13745: [web] update ThreadAvatar component to pass farcaster channel ID to useResolvedThreadAvatar.Thu, Oct 17, 5:53 AM

varun added inline comments.Thu, Oct 17, 5:57 AM

lib/shared/avatar-utils.js
347–354	this is an unrelated change but felt it was small enough to include here

Harbormaster completed remote builds in B32290: Diff 45252.Thu, Oct 17, 6:11 AM

varun published this revision for review.Thu, Oct 17, 8:57 PM

varun added inline comments.

lib/shared/avatar-utils.js
369	we want these types to be mutually exclusive to avoid confusion when the avatar type is 'farcaster' and the function caller provides a farcaster channel ID and a user FID

Revision Contents
Changeset List

Path

Size

lib/

shared/

avatar-utils.js

39 lines

Diff 45252

View Options

lib/shared/avatar-utils.js

[lib] use fc channel avatar url in useResolvedThreadAvatarNeeds ReviewPublicActions