Page MenuHomePhabricator
Differential D13746

[native] update ThreadAvatar component to pass farcaster channel ID to useResolvedThreadAvatar
ClosedPublic
Actions

Authored by varun on Oct 17 2024, 5:54 AM.
Tags
None
Referenced Files
F3363726: D13746.id45254.diff
Mon, Nov 25, 3:13 AM
Unknown Object (File)
Sat, Nov 23, 1:00 PM
Unknown Object (File)
Sat, Nov 23, 7:38 AM
Unknown Object (File)
Fri, Nov 22, 5:30 PM
Unknown Object (File)
Fri, Nov 22, 5:29 PM
Unknown Object (File)
Fri, Nov 22, 12:52 AM
Unknown Object (File)
Thu, Nov 21, 6:23 PM
Unknown Object (File)
Wed, Nov 20, 8:17 AM
View All 28 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM37b7cae62c30: [native] update ThreadAvatar component to pass farcaster channel ID to…
Summary

Depends on D13745

pass an object containing username/fid or an object containing a farcaster channel ID to useResolvedThreadAvatar

Test Plan

modified threads table in mariadb successfully set thread avatars for all threads in a tagged community to the fc channel image. was able to change child threads to other avatar types

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Oct 17 2024, 5:54 AM
varun held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptOct 17 2024, 5:54 AM
Harbormaster completed remote builds in B32292: Diff 45254.Oct 17 2024, 6:28 AM
varun published this revision for review.Oct 17 2024, 9:02 PM
varun added a child revision: D13749: [lib] modify rawThreadInfoFromServerThreadInfo to return default avatar to old clients.Oct 17 2024, 10:13 PM
ashoat accepted this revision.Oct 20 2024, 11:38 AM

I would've included these changes in D13745... makes it easier to review when the pair of changes is in the same diff

native/avatars/thread-avatar.react.js
67–72

Left feedback in D13744, but I think it would be better to pass both in

This revision is now accepted and ready to land.Oct 20 2024, 11:38 AM
varun updated this revision to Diff 45325.Oct 22 2024, 4:06 PM

rebase

Harbormaster completed remote builds in B32336: Diff 45325.Oct 22 2024, 4:35 PM
Closed by commit rCOMM37b7cae62c30: [native] update ThreadAvatar component to pass farcaster channel ID to… (authored by varun). · Explain WhyOct 22 2024, 9:51 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM37b7cae62c30: [native] update ThreadAvatar component to pass farcaster channel ID to….

Revision Contents
Changeset List

PathSize
native/
avatars/
23 lines

Diff 45254

View Options

native/avatars/thread-avatar.react.js

Loading...